You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sc...@apache.org on 2005/09/04 12:30:52 UTC

svn commit: r278573 - in /jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives: ArrayUnsignedByteList.java ArrayUnsignedIntList.java ArrayUnsignedShortList.java

Author: scolebourne
Date: Sun Sep  4 03:30:45 2005
New Revision: 278573

URL: http://svn.apache.org/viewcvs?rev=278573&view=rev
Log:
Remove unecessary casts
bug 35836, from Nathan Beyer

Modified:
    jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedByteList.java
    jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedIntList.java
    jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedShortList.java

Modified: jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedByteList.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedByteList.java?rev=278573&r1=278572&r2=278573&view=diff
==============================================================================
--- jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedByteList.java (original)
+++ jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedByteList.java Sun Sep  4 03:30:45 2005
@@ -233,7 +233,7 @@
     //-------------------------------------------------------------------------
 
     private final short toShort(byte value) { 
-        return (short)(((short)value)&MAX_VALUE);
+        return (short)(value & MAX_VALUE);
     }
 
     private final byte fromShort(short value) {

Modified: jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedIntList.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedIntList.java?rev=278573&r1=278572&r2=278573&view=diff
==============================================================================
--- jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedIntList.java (original)
+++ jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedIntList.java Sun Sep  4 03:30:45 2005
@@ -233,7 +233,7 @@
     //-------------------------------------------------------------------------
 
     private final long toLong(int value) { 
-        return ((long)value)&MAX_VALUE;
+        return value & MAX_VALUE;
     }
 
     private final int fromLong(long value) {

Modified: jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedShortList.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedShortList.java?rev=278573&r1=278572&r2=278573&view=diff
==============================================================================
--- jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedShortList.java (original)
+++ jakarta/commons/proper/primitives/trunk/src/java/org/apache/commons/collections/primitives/ArrayUnsignedShortList.java Sun Sep  4 03:30:45 2005
@@ -233,7 +233,7 @@
     //-------------------------------------------------------------------------
 
     private final int toInt(short value) { 
-        return ((int)value)&MAX_VALUE;
+        return value & MAX_VALUE;
     }
 
     private final short fromInt(int value) {



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org