You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Arrigo Marchiori <ar...@yahoo.it.INVALID> on 2021/01/06 14:19:57 UTC
Re: AOO 4.1.9 Info - bug 127952
Hello All,
On Tue, Jan 05, 2021 at 04:21:47PM -0500, Keith N. McKenna wrote:
> On 1/5/2021 12:46 PM, Arrigo Marchiori wrote:
> > Hello All,
> >
> > On Tue, Jan 05, 2021 at 02:42:47PM +0100, Matthias Seidel wrote:
> >
> >> Hi Jim,
> >>
> >> Am 05.01.21 um 14:29 schrieb Jim Jagielski:
> >>>
> >>>> On Jan 5, 2021, at 7:51 AM, Matthias Seidel <ma...@hamburg.de> wrote:
> >>>>
> >>>> Hi Jim,
> >>>>
> >>>> Am 05.01.21 um 13:29 schrieb Jim Jagielski:
> >>>>> Should we try for a RC1 early next week?
> >>>> I didn't hear any response regarding this issue yet:
> >>>>
> >>>> https://bz.apache.org/ooo/show_bug.cgi?id=128413 <https://bz.apache.org/ooo/show_bug.cgi?id=128413>
> >>> This was handled by making fakeroot required:
> >>>
> >>> https://github.com/apache/openoffice/commit/4975252caf49bc46c383c6cef330cb927a635806
> >>
> >> OK, but did anyone confirm it with the test builds?
> >
> > I can confirm that the Italian test builds in DEB format did not show
> > the problem.
> >
> > I am confident that the bug was fixed by Jim's commit.
> >
> >> And besides Keith I didn't see any tests on the Windows builds.
> >
> > I tried to ask if there is a procedure to follow for testing [1].
> > Do we have any? I can follow it for the Italian builds.
> >
> > Best regards.
> >
> > References:
> >
> > 1: https://lists.apache.org/thread.html/r54b17e3692b4207a1c9cdb132d836a7b803d2f65b354852999cccc2c%40%3Cdev.openoffice.apache.org%3E
> >
> Arrigio;
>
> There is a lot of QA information on the wiki at:
> https://wiki.openoffice.org/wiki/QA. A lot of the information is either
> dated, or obsolete but there is still much good information that can be
> used.
I tried to look into it... and it's really too much for me at the
moment. I am sorry. If you have any ready-made checklist I will be
happy to go through it, but I could not make much sense out of the QA
section at the moment...
...except for the idea of verifying the bugs "changed after" the
release date. I used the date for 4.1.7 and I found this:
https://bz.apache.org/ooo/show_bug.cgi?id=127952
The fun (?) fact is that:
- the AOO 4.1.9 build for Windows by Matthias can open the file;
- Jim's RPM builds for Linux _crash_ while opening that file;
- My own build of trunk on Linux can open the file.
Do you think that this is worth more investigation before releasing
4.1.9?
Best regards,
--
Arrigo
http://rigo.altervista.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: AOO 4.1.9 Info - bug 127952
Posted by Jim Jagielski <ji...@jaguNET.com>.
This seems like a safe and non-controversial fix to me...
> On Jan 7, 2021, at 4:31 PM, Arrigo Marchiori <ar...@yahoo.it.INVALID> wrote:
>
> Hello,
>
> On Wed, Jan 06, 2021 at 07:03:19AM -0800, Don Lewis wrote:
>
>> On 6 Jan, Jim Jagielski wrote:
>>>
>>>
>>>> On Jan 6, 2021, at 9:19 AM, Arrigo Marchiori <ar...@yahoo.it.INVALID> wrote:
>>>>
>>>> Hello All,
>>>>
>>>>
>>>> - My own build of trunk on Linux can open the file.
>>>>
>>>> Do you think that this is worth more investigation before releasing
>>>> 4.1.9?
>>>>
>>>
>>> AFAICT, it is not a regression (trunk and 4.1.x are very different)... So I don't
>>> think it should hold off 4.1.9-RC1 IMO
>>
>> Agreed. Who knows how long this would take to understand, fix, and
>> test. In the meantime, there are a lot of Big Sur users waiting on
>> 4.1.9.
>
> In the hope it can be useful, please see here:
> https://github.com/apache/openoffice/pull/116 <https://github.com/apache/openoffice/pull/116>
>
> Apparently, Linux crashes because certain stacks are pop()-ed without
> ever being push()-ed before.
>
> My personal theory is that Windows's standard library may add some
> implicit checks, and for this reason Windows builds do not seem to
> crash.
>
> The PR addresses the ``symptoms'' of a wrong parsing. The parsing
> itself should be fixed, but maybe this ``quick&dirty'' fix is ok for a
> minor release, if it avoids a blatant crash?
>
> I hope it can be useful. It applies to trunk and AOO419 so it should
> be easily integrated ``at the last minute'' if we found it's worth it.
>
> Best regards,
> --
> Arrigo
>
> http://rigo.altervista.org <http://rigo.altervista.org/>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org <ma...@openoffice.apache.org>
> For additional commands, e-mail: dev-help@openoffice.apache.org <ma...@openoffice.apache.org>
Re: AOO 4.1.9 Info - bug 127952
Posted by Arrigo Marchiori <ar...@yahoo.it.INVALID>.
Hello,
On Wed, Jan 06, 2021 at 07:03:19AM -0800, Don Lewis wrote:
> On 6 Jan, Jim Jagielski wrote:
> >
> >
> >> On Jan 6, 2021, at 9:19 AM, Arrigo Marchiori <ar...@yahoo.it.INVALID> wrote:
> >>
> >> Hello All,
> >>
> >>
> >> - My own build of trunk on Linux can open the file.
> >>
> >> Do you think that this is worth more investigation before releasing
> >> 4.1.9?
> >>
> >
> > AFAICT, it is not a regression (trunk and 4.1.x are very different)... So I don't
> > think it should hold off 4.1.9-RC1 IMO
>
> Agreed. Who knows how long this would take to understand, fix, and
> test. In the meantime, there are a lot of Big Sur users waiting on
> 4.1.9.
In the hope it can be useful, please see here:
https://github.com/apache/openoffice/pull/116
Apparently, Linux crashes because certain stacks are pop()-ed without
ever being push()-ed before.
My personal theory is that Windows's standard library may add some
implicit checks, and for this reason Windows builds do not seem to
crash.
The PR addresses the ``symptoms'' of a wrong parsing. The parsing
itself should be fixed, but maybe this ``quick&dirty'' fix is ok for a
minor release, if it avoids a blatant crash?
I hope it can be useful. It applies to trunk and AOO419 so it should
be easily integrated ``at the last minute'' if we found it's worth it.
Best regards,
--
Arrigo
http://rigo.altervista.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: AOO 4.1.9 Info - bug 127952
Posted by Don Lewis <tr...@apache.org>.
On 6 Jan, Jim Jagielski wrote:
>
>
>> On Jan 6, 2021, at 9:19 AM, Arrigo Marchiori <ar...@yahoo.it.INVALID> wrote:
>>
>> Hello All,
>>
>>
>> - My own build of trunk on Linux can open the file.
>>
>> Do you think that this is worth more investigation before releasing
>> 4.1.9?
>>
>
> AFAICT, it is not a regression (trunk and 4.1.x are very different)... So I don't
> think it should hold off 4.1.9-RC1 IMO
Agreed. Who knows how long this would take to understand, fix, and
test. In the meantime, there are a lot of Big Sur users waiting on
4.1.9.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: AOO 4.1.9 Info - bug 127952
Posted by Jim Jagielski <ji...@jaguNET.com>.
> On Jan 6, 2021, at 9:19 AM, Arrigo Marchiori <ar...@yahoo.it.INVALID> wrote:
>
> Hello All,
>
>
> - My own build of trunk on Linux can open the file.
>
> Do you think that this is worth more investigation before releasing
> 4.1.9?
>
AFAICT, it is not a regression (trunk and 4.1.x are very different)... So I don't
think it should hold off 4.1.9-RC1 IMO