You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/02 12:56:07 UTC

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1294: Doc: Update README

LaurenceLiZhixin commented on a change in pull request #1294:
URL: https://github.com/apache/dubbo-go/pull/1294#discussion_r662992197



##########
File path: README.md
##########
@@ -14,9 +14,9 @@ Apache Dubbo-go, a Dubbo implementation written in Golang, is born to bridge the
 
 ## Architecture
 
-![dubbo go extend](https://dubbogo.github.io/img/doc/dubbo-go3.0-arch.jpg)
+![dubbo go extend](./doc/pic/arch/dubbo-go3.0-arch.jpg)

Review comment:
       为什么把图片放到当前仓库了?这样会增大框架空间，不太合理。另外，这两个图片有区别吗？

##########
File path: README_CN.md
##########
@@ -14,7 +14,7 @@ Apache Dubbo Go 语言实现，架起 Java 和 Golang 之间的桥梁，与 gRPC
 
 ## 架构
 
-![dubbo go extend](https://dubbogo.github.io/img/doc/dubbo-go3.0-arch.jpg)
+![dubbo go extend](./doc/pic/arch/dubbo-go3.0-arch.jpg)

Review comment:
       这里也是，为什么放到这里了？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org