You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/01/27 00:03:46 UTC

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1940
  
    Thanks @1ambda for contributing very interesting new feature.
    I've play around with it and have couple of feedbacks.
    
    ### Couldn't make Spell as display system work
    > The most important thing is, spell is not only interpreter but also display system. Because it runs on browser. This enable us to combine existing backend interpreters with spell like
    
    So i tried following but couldn't make it work. Am i missing something?
    ![image](https://cloud.githubusercontent.com/assets/1540981/22355380/9d932722-e46d-11e6-8d80-af5e7657d910.png)
    
    ### Configuring Display order of Spell doesn't make sense
    
    Enabled spells are displayed in 'Helium' menu like below.
    ![image](https://cloud.githubusercontent.com/assets/1540981/22355499/37ea7ef6-e46e-11e6-8a41-8083f836d07e.png)
    
    Which is designed to change display order of visualization package when they displayed in chart selector inside of the paragraph.
    As far as i understand, Spell does not have to be listed in the chart selector and does not have to be listed there and change order. So i think reordering should be only for 'Visualization' type package.
    
    I think Spell can create another section just below enabled visualization buttons, to list enabled spells.
    
    ### Display keyword of the spell
    
    Each spell has keyword to invoke. For example `markdown-spell`'s keyword is `%markdown`, `flowchart-spell`'s keyword is `%flowchart`. However, i couldn't find these keyword anywhere but the source code.
    
    So it'll be nice if 'Helium' menu displays keyword of the Spell type packages. 
    
    
    ### Example for example spells 
    
    If there's some informations or example that how to use (syntax, etc) included example Spells, (e.g. in description section or somewhere) it'll be more convenient. 
    
    
    
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---