You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "reschke (via GitHub)" <gi...@apache.org> on 2025/04/29 16:36:40 UTC
[PR] SLING-12769: alias refactoring - MapEntries - move logic related to alias events into AliasHandler [sling-org-apache-sling-resourceresolver]
reschke opened a new pull request, #174:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/174
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12769: alias refactoring - MapEntries - move logic related to alias events into AliasHandler [sling-org-apache-sling-resourceresolver]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #174:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/174#discussion_r2068740058
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/AliasHandler.java:
##########
@@ -159,7 +159,11 @@ boolean usesCache() {
}
boolean doAddAlias(final Resource resource) {
- return loadAlias(resource, this.aliasMapsMap, null, null);
+ if (cacheIsInitialized) {
Review Comment:
I have removed the redundant flag and added a TODO for further concurrency checks (not limited to this change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12769: alias refactoring - MapEntries - move logic related to alias events into AliasHandler [sling-org-apache-sling-resourceresolver]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on code in PR #174:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/174#discussion_r2068191260
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/AliasHandler.java:
##########
@@ -159,7 +159,11 @@ boolean usesCache() {
}
boolean doAddAlias(final Resource resource) {
- return loadAlias(resource, this.aliasMapsMap, null, null);
+ if (cacheIsInitialized) {
Review Comment:
right now ``cacheIsInitialized`` is not marked as volatile. But with this change (or maybe even before) we should do that, as it can be accessed by multiple threads (at least that's my assumption).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12769: alias refactoring - MapEntries - move logic related to alias events into AliasHandler [sling-org-apache-sling-resourceresolver]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke merged PR #174:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12769: alias refactoring - MapEntries - move logic related to alias events into AliasHandler [sling-org-apache-sling-resourceresolver]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #174:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/174#issuecomment-2842117947
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [96.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12769: alias refactoring - MapEntries - move logic related to alias events into AliasHandler [sling-org-apache-sling-resourceresolver]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #174:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/174#issuecomment-2839553478
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [96.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=174)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org