You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2019/10/07 11:51:43 UTC
[VOTE] Release Apache Tomcat 9.0.27
The proposed Apache Tomcat 9.0.27 release is now available for voting.
The major changes compared to the 9.0.26 release are:
- Update to Commons Daemon 1.2.2 to pick up the fix for a regression in
Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when
running on a Windows OS that had not been fully updated.
- Fix some edge cases with NIO2 and TLS that could has a request to
hang.
- Fix a memory leak introduced by the HTTP/2 timeout refactoring in
9.0.23 that could occur when HTTP/2 or WebSocket was used.
Along with lots of other bug fixes and improvements.
For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.27/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1233/
The tag is:
https://github.com/apache/tomcat/tree/9.0.27
The proposed 9.0.27 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 9.0.27
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.27
Posted by Rémy Maucherat <re...@apache.org>.
On Mon, Oct 7, 2019 at 1:51 PM Mark Thomas <ma...@apache.org> wrote:
> The proposed Apache Tomcat 9.0.27 release is now available for voting.
>
> The major changes compared to the 9.0.26 release are:
>
> - Update to Commons Daemon 1.2.2 to pick up the fix for a regression in
> Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when
> running on a Windows OS that had not been fully updated.
>
> - Fix some edge cases with NIO2 and TLS that could has a request to
> hang.
>
> - Fix a memory leak introduced by the HTTP/2 timeout refactoring in
> 9.0.23 that could occur when HTTP/2 or WebSocket was used.
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.27/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1233/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.27
>
>
> The proposed 9.0.27 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.27
>
Nice polish release, it will be quite handy for my Graal demo too.
Rémy
[VOTE][RESULT] Release Apache Tomcat 9.0.27
Posted by Mark Thomas <ma...@apache.org>.
The following votes were cast:
Binding:
+1: remm, ebourg, csutherl, mgrigorov, kkolinko, markt
No other votes were cast.
The vote therefore passes.
Thanks to everyone who contributed to this release.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.27
Posted by Konstantin Kolinko <kn...@gmail.com>.
пн, 7 окт. 2019 г. в 14:51, Mark Thomas <ma...@apache.org>:
>
> The proposed Apache Tomcat 9.0.27 release is now available for voting.
>
> The major changes compared to the 9.0.26 release are:
>
> - Update to Commons Daemon 1.2.2 to pick up the fix for a regression in
> Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when
> running on a Windows OS that had not been fully updated.
>
> - Fix some edge cases with NIO2 and TLS that could has a request to
> hang.
>
> - Fix a memory leak introduced by the HTTP/2 timeout refactoring in
> 9.0.23 that could occur when HTTP/2 or WebSocket was used.
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.27/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1233/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.27
>
>
> The proposed 9.0.27 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 9.0.27
Tested on Windows 10, with JDK 8u222 from AdoptOpenJDK (64-bit,
Hotspot), OpenJDK 13.0 from Oracle (64-bit) x All connectors.
All tests OK except org.apache.tomcat.jni.TestSocketServer (already
reported, and fixed by Mark in master).
Smoke testing with Security Manager: OK.
Windows installer: install, uninstall: OK
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.27
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 07/10/2019 à 13:51, Mark Thomas a écrit :
> The proposed 9.0.27 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.27
Tested on Debian with OpenJDK 11.0.5+6, OpenSSL 1.1.1d and Tomcat Native
1.2.23. No failure on the 3 test suites.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.27
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
On Mon, Oct 7, 2019 at 2:51 PM Mark Thomas <ma...@apache.org> wrote:
> The proposed Apache Tomcat 9.0.27 release is now available for voting.
>
> The major changes compared to the 9.0.26 release are:
>
> - Update to Commons Daemon 1.2.2 to pick up the fix for a regression in
> Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when
> running on a Windows OS that had not been fully updated.
>
> - Fix some edge cases with NIO2 and TLS that could has a request to
> hang.
>
> - Fix a memory leak introduced by the HTTP/2 timeout refactoring in
> 9.0.23 that could occur when HTTP/2 or WebSocket was used.
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.27/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1233/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.27
>
>
> The proposed 9.0.27 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 9.0.27
>
Regards,
Martin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Re: [VOTE] Release Apache Tomcat 9.0.27
Posted by Konstantin Kolinko <kn...@gmail.com>.
вт, 8 окт. 2019 г. в 21:00, Mark Thomas <ma...@apache.org>:
>
> On 08/10/2019 17:49, Mark Thomas wrote:
> > On 07/10/2019 17:40, Igal Sapir wrote:
> >> Mark,
> >>
> >> On 10/7/2019 4:51 AM, Mark Thomas wrote:
> >>> The proposed Apache Tomcat 9.0.27 release is now available for voting.
> >>
> >> I'm getting the failures below [1] for unit tests on Windows 10 with
> >> Java 1.8u181. False positives?
> >
> > Don't know yet. I didn't get the same failures on Windows but I was
> > using a different OS and a different JRE.
> >
> >> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt: FAILED
> >> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-expected:<...3-Header-[:status]-[[304]
> >> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]]
> >> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[date]-[W...>
> >> but was:<...3-Header-[:status]-[[200]
> >> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[accept-ranges]-[bytes]
> >> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]
> >
> > This is TestStreamProcessor.testPrepareHeaders() failing for each connector.
>
> I think the machine you are using for testing has some sort of issue
> with its clock.
>
> The above test will fail like that if the last modified time of the file
> being requested is ahead of the current time. I don't see how that can
> happen - even if the tests have just been checked out - unless the clock
> moves back in time for some reason.
The file requested by the test is test/webapp/index.html
When a release candidate is being tested a usual approach is to unpack
a source archive and test it.
Depending on time zone differences between the one who created the
archive and the one unpacking it the date of the source file may be in
the future (if the archive was created less than 24 hours ago). ;-)
> Overall, I'm not concerned about these failures although I am interested
> to hear of you find out what is going on.
+1
> Mark
>
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.27
Posted by Mark Thomas <ma...@apache.org>.
On 08/10/2019 17:49, Mark Thomas wrote:
> On 07/10/2019 17:40, Igal Sapir wrote:
>> Mark,
>>
>> On 10/7/2019 4:51 AM, Mark Thomas wrote:
>>> The proposed Apache Tomcat 9.0.27 release is now available for voting.
>>
>> I'm getting the failures below [1] for unit tests on Windows 10 with
>> Java 1.8u181. False positives?
>
> Don't know yet. I didn't get the same failures on Windows but I was
> using a different OS and a different JRE.
>
>> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt: FAILED
>> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-expected:<...3-Header-[:status]-[[304]
>> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]]
>> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[date]-[W...>
>> but was:<...3-Header-[:status]-[[200]
>> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[accept-ranges]-[bytes]
>> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]
>
> This is TestStreamProcessor.testPrepareHeaders() failing for each connector.
I think the machine you are using for testing has some sort of issue
with its clock.
The above test will fail like that if the last modified time of the file
being requested is ahead of the current time. I don't see how that can
happen - even if the tests have just been checked out - unless the clock
moves back in time for some reason.
Overall, I'm not concerned about these failures although I am interested
to hear of you find out what is going on.
Mark
>
> <snip/>
>
>> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt: FAILED
>> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-Socket.timeoutSet
>> failed (<1s) [999760800] +-[400]
>> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-junit.framework.AssertionFailedError:
>> Socket.timeoutSet failed (<1s) [999760800] +-[400]
>> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt- at
>> org.apache.tomcat.jni.TestSocketServer.testBlockingReadFromClientWithTimeout(TestSocketServer.java:111)
>>
>> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-
>> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-Testcase: testPort
>> took 0.001 sec
>
> That is a false positive. The timing variance is significantly greater
> than the error margin. It looks like we need to adjust that. Interesting
> that the socket waited a little less than a second to timeout. We'd need
> to increase the error margin by 3 orders of magnitude (400ns to 0.4ms)
> for that test to pass.
>
> I'll start looking into these but more eyes are always welcome.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.27
Posted by Mark Thomas <ma...@apache.org>.
On 07/10/2019 17:40, Igal Sapir wrote:
> Mark,
>
> On 10/7/2019 4:51 AM, Mark Thomas wrote:
>> The proposed Apache Tomcat 9.0.27 release is now available for voting.
>
> I'm getting the failures below [1] for unit tests on Windows 10 with
> Java 1.8u181. False positives?
Don't know yet. I didn't get the same failures on Windows but I was
using a different OS and a different JRE.
> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt: FAILED
> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-expected:<...3-Header-[:status]-[[304]
> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]]
> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[date]-[W...>
> but was:<...3-Header-[:status]-[[200]
> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[accept-ranges]-[bytes]
> TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]
This is TestStreamProcessor.testPrepareHeaders() failing for each connector.
<snip/>
> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt: FAILED
> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-Socket.timeoutSet
> failed (<1s) [999760800] +-[400]
> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-junit.framework.AssertionFailedError:
> Socket.timeoutSet failed (<1s) [999760800] +-[400]
> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt- at
> org.apache.tomcat.jni.TestSocketServer.testBlockingReadFromClientWithTimeout(TestSocketServer.java:111)
>
> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-
> TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-Testcase: testPort
> took 0.001 sec
That is a false positive. The timing variance is significantly greater
than the error margin. It looks like we need to adjust that. Interesting
that the socket waited a little less than a second to timeout. We'd need
to increase the error margin by 3 orders of magnitude (400ns to 0.4ms)
for that test to pass.
I'll start looking into these but more eyes are always welcome.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.27
Posted by Igal Sapir <is...@apache.org>.
Mark,
On 10/7/2019 4:51 AM, Mark Thomas wrote:
> The proposed Apache Tomcat 9.0.27 release is now available for voting.
I'm getting the failures below [1] for unit tests on Windows 10 with
Java 1.8u181. False positives?
Igal
[1] output\build\logs> grep -A 5 FAILED * */*
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt: FAILED
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-expected:<...3-Header-[:status]-[[304]
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]]
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[date]-[W...>
but was:<...3-Header-[:status]-[[200]
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[accept-ranges]-[bytes]
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]
--
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt: FAILED
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-expected:<...3-Header-[:status]-[[304]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[etag]-[W/"957-1447269522000"]]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[date]-[W...>
but was:<...3-Header-[:status]-[[200]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[accept-ranges]-[bytes]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[etag]-[W/"957-1447269522000"]
--
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt: FAILED
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-expected:<...3-Header-[:status]-[[304]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[etag]-[W/"957-1447269522000"]]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[date]-[W...>
but was:<...3-Header-[:status]-[[200]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[accept-ranges]-[bytes]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[etag]-[W/"957-1447269522000"]
--
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt: FAILED
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-Socket.timeoutSet
failed (<1s) [999760800] +-[400]
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-junit.framework.AssertionFailedError:
Socket.timeoutSet failed (<1s) [999760800] +-[400]
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt- at
org.apache.tomcat.jni.TestSocketServer.testBlockingReadFromClientWithTimeout(TestSocketServer.java:111)
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-Testcase: testPort
took 0.001 sec
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.27
Posted by Coty Sutherland <cs...@apache.org>.
On Mon, Oct 7, 2019 at 7:51 AM Mark Thomas <ma...@apache.org> wrote:
> The proposed Apache Tomcat 9.0.27 release is now available for voting.
>
> The major changes compared to the 9.0.26 release are:
>
> - Update to Commons Daemon 1.2.2 to pick up the fix for a regression in
> Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when
> running on a Windows OS that had not been fully updated.
>
> - Fix some edge cases with NIO2 and TLS that could has a request to
> hang.
>
> - Fix a memory leak introduced by the HTTP/2 timeout refactoring in
> 9.0.23 that could occur when HTTP/2 or WebSocket was used.
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.27/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1233/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.27
>
>
> The proposed 9.0.27 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 9.0.27
>
+1 LGTM. Tested on Fedora 30 with OpenSSL 1.1.1d and tcnative 1.2.21.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Re: [VOTE] Release Apache Tomcat 9.0.27
Posted by Mark Thomas <ma...@apache.org>.
On 07/10/2019 12:51, Mark Thomas wrote:
> The proposed 9.0.27 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.27
Unit tests pass for NIO, NIO2 and APR/native with Tomcat Native 1.2.23
on Linux, Windows and MacOS.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org