You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Abhishek Bafna <ba...@gmail.com> on 2016/07/08 15:34:49 UTC
Re: Review Request 48469: OOZIE-2517 Add support for startCreatedTime
and endCreatedTime filters for coord and bundles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48469/
-----------------------------------------------------------
(Updated July 8, 2016, 3:34 p.m.)
Review request for oozie.
Bugs: OOZIE-2517
https://issues.apache.org/jira/browse/OOZIE-2517
Repository: oozie-git
Description
-------
Add support for startCreatedTime and endCreatedTime filters for coord and bundles
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 79d0d97
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 4b631c1
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java bfd1dae
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java c924f44
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java d442aa8
core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 52d3e9d
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 54bfc16
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 5714040
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java 97cbb7f
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 5335213
Diff: https://reviews.apache.org/r/48469/diff/
Testing
-------
unit tests done. Manual testing done.
Thanks,
Abhishek Bafna
Re: Review Request 48469: OOZIE-2517 Add support for startCreatedTime
and endCreatedTime filters for coord and bundles
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48469/#review146553
-----------------------------------------------------------
Ship it!
Ship It!
- Jaydeep Vishwakarma
On July 27, 2016, 4:38 a.m., Abhishek Bafna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48469/
> -----------------------------------------------------------
>
> (Updated July 27, 2016, 4:38 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2517
> https://issues.apache.org/jira/browse/OOZIE-2517
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add support for startCreatedTime and endCreatedTime filters for coord and bundles
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2301908
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java dace4e8
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java 8fcb1e6
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java 5cde60e
> core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java ebdbaa4
> core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 90c772f
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6529bfa
> core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 14bbbbb
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java e98b146
> docs/src/site/twiki/WebServicesAPI.twiki 5dadafe
>
> Diff: https://reviews.apache.org/r/48469/diff/
>
>
> Testing
> -------
>
> unit tests done. Manual testing done.
>
>
> Thanks,
>
> Abhishek Bafna
>
>
Re: Review Request 48469: OOZIE-2517 Add support for startCreatedTime
and endCreatedTime filters for coord and bundles
Posted by Abhishek Bafna <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48469/
-----------------------------------------------------------
(Updated July 27, 2016, 4:38 a.m.)
Review request for oozie.
Bugs: OOZIE-2517
https://issues.apache.org/jira/browse/OOZIE-2517
Repository: oozie-git
Description
-------
Add support for startCreatedTime and endCreatedTime filters for coord and bundles
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2301908
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java dace4e8
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java 8fcb1e6
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java 5cde60e
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java ebdbaa4
core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 90c772f
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6529bfa
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 14bbbbb
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java e98b146
docs/src/site/twiki/WebServicesAPI.twiki 5dadafe
Diff: https://reviews.apache.org/r/48469/diff/
Testing
-------
unit tests done. Manual testing done.
Thanks,
Abhishek Bafna
Re: Review Request 48469: OOZIE-2517 Add support for startCreatedTime
and endCreatedTime filters for coord and bundles
Posted by Abhishek Bafna <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48469/
-----------------------------------------------------------
(Updated July 26, 2016, 6:18 p.m.)
Review request for oozie.
Bugs: OOZIE-2517
https://issues.apache.org/jira/browse/OOZIE-2517
Repository: oozie-git
Description
-------
Add support for startCreatedTime and endCreatedTime filters for coord and bundles
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2301908
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java dace4e8
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java 8fcb1e6
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java 5cde60e
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java ebdbaa4
core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 90c772f
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 6529bfa
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 14bbbbb
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java e98b146
docs/src/site/twiki/WebServicesAPI.twiki 5dadafe
Diff: https://reviews.apache.org/r/48469/diff/
Testing
-------
unit tests done. Manual testing done.
Thanks,
Abhishek Bafna
Re: Review Request 48469: OOZIE-2517 Add support for startCreatedTime
and endCreatedTime filters for coord and bundles
Posted by Abhishek Bafna <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48469/
-----------------------------------------------------------
(Updated July 26, 2016, 4:37 p.m.)
Review request for oozie.
Bugs: OOZIE-2517
https://issues.apache.org/jira/browse/OOZIE-2517
Repository: oozie-git
Description
-------
Add support for startCreatedTime and endCreatedTime filters for coord and bundles
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 79d0d97
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 4b631c1
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java bfd1dae
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java c924f44
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java 00d2263
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java d442aa8
core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 52d3e9d
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 54bfc16
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 5714040
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java 97cbb7f
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 5335213
docs/src/site/twiki/WebServicesAPI.twiki a34f2d3
Diff: https://reviews.apache.org/r/48469/diff/
Testing
-------
unit tests done. Manual testing done.
Thanks,
Abhishek Bafna
Re: Review Request 48469: OOZIE-2517 Add support for startCreatedTime
and endCreatedTime filters for coord and bundles
Posted by Abhishek Bafna <ba...@gmail.com>.
> On July 25, 2016, 7:23 p.m., Jaydeep Vishwakarma wrote:
> > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java, line 321
> > <https://reviews.apache.org/r/48469/diff/2/?file=1439717#file1439717line321>
> >
> > where is the refectoring of WorkflowsJobGetJPAExecutor.parseCreatedTimeString, Not seeing removal of the code from there?
This patch/bug does not contains the refactoring. Because it can cause conflicts for OOZIE-2461 and OOZIE-2520. The refactoring will require chnaging parseCreatedTimeString(), execute(), filter() etc. methods to updated across multiple classes. Update to testcases as well.
> On July 25, 2016, 7:23 p.m., Jaydeep Vishwakarma wrote:
> > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java, line 350
> > <https://reviews.apache.org/r/48469/diff/2/?file=1439717#file1439717line350>
> >
> > mention the correct format.
Done.
> On July 25, 2016, 7:23 p.m., Jaydeep Vishwakarma wrote:
> > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java, line 353
> > <https://reviews.apache.org/r/48469/diff/2/?file=1439717#file1439717line353>
> >
> > mention the format as well.
Done.
> On July 25, 2016, 7:23 p.m., Jaydeep Vishwakarma wrote:
> > core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java, line 21
> > <https://reviews.apache.org/r/48469/diff/2/?file=1439720#file1439720line21>
> >
> > imported only used classes.
Done.
> On July 25, 2016, 7:23 p.m., Jaydeep Vishwakarma wrote:
> > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java, line 21
> > <https://reviews.apache.org/r/48469/diff/2/?file=1439722#file1439722line21>
> >
> > same here
Done.
> On July 25, 2016, 7:23 p.m., Jaydeep Vishwakarma wrote:
> > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java, line 66
> > <https://reviews.apache.org/r/48469/diff/2/?file=1439722#file1439722line66>
> >
> > can you add some negative condition test cases as well?
Added a negative testcase based on wrong time format.
- Abhishek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48469/#review143413
-----------------------------------------------------------
On July 8, 2016, 3:34 p.m., Abhishek Bafna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48469/
> -----------------------------------------------------------
>
> (Updated July 8, 2016, 3:34 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2517
> https://issues.apache.org/jira/browse/OOZIE-2517
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add support for startCreatedTime and endCreatedTime filters for coord and bundles
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 79d0d97
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 4b631c1
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java bfd1dae
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java c924f44
> core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java d442aa8
> core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 52d3e9d
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 54bfc16
> core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 5714040
> core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java 97cbb7f
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 5335213
>
> Diff: https://reviews.apache.org/r/48469/diff/
>
>
> Testing
> -------
>
> unit tests done. Manual testing done.
>
>
> Thanks,
>
> Abhishek Bafna
>
>
Re: Review Request 48469: OOZIE-2517 Add support for startCreatedTime
and endCreatedTime filters for coord and bundles
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48469/#review143413
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java (line 321)
<https://reviews.apache.org/r/48469/#comment209194>
where is the refectoring of WorkflowsJobGetJPAExecutor.parseCreatedTimeString, Not seeing removal of the code from there?
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java (line 350)
<https://reviews.apache.org/r/48469/#comment209195>
mention the correct format.
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java (line 353)
<https://reviews.apache.org/r/48469/#comment209193>
mention the format as well.
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java (line 21)
<https://reviews.apache.org/r/48469/#comment209196>
imported only used classes.
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java (line 21)
<https://reviews.apache.org/r/48469/#comment209197>
same here
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java (line 62)
<https://reviews.apache.org/r/48469/#comment209200>
can you add some negative condition test cases as well?
- Jaydeep Vishwakarma
On July 8, 2016, 3:34 p.m., Abhishek Bafna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48469/
> -----------------------------------------------------------
>
> (Updated July 8, 2016, 3:34 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2517
> https://issues.apache.org/jira/browse/OOZIE-2517
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Add support for startCreatedTime and endCreatedTime filters for coord and bundles
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 79d0d97
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 4b631c1
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java bfd1dae
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java c924f44
> core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java d442aa8
> core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 52d3e9d
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 54bfc16
> core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 5714040
> core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java 97cbb7f
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 5335213
>
> Diff: https://reviews.apache.org/r/48469/diff/
>
>
> Testing
> -------
>
> unit tests done. Manual testing done.
>
>
> Thanks,
>
> Abhishek Bafna
>
>