You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/09 11:28:10 UTC
[GitHub] [ozone] sodonnel opened a new pull request #3062: HDDS-6259. EC: Pipelines for closed containers should contain correct replica indexes
sodonnel opened a new pull request #3062:
URL: https://github.com/apache/ozone/pull/3062
## What changes were proposed in this pull request?
Note this also containers #3048, so it will need to be committed first and then this one rebased.
The pipeline returned from SCM for EC closed containers and closed pipelines does not carry the correct replica index with
the datanode list. This means the replicas are not returned in the correct order resulting in strange errors reading EC data, such as wrong data returned and "insufficient nodes" errors when there are enough nodes available.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6259
## How was this patch tested?
New and existing tests along with some manual testing in docker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao merged pull request #3062: HDDS-6259. EC: Pipelines for closed containers should contain correct replica indexes
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged pull request #3062:
URL: https://github.com/apache/ozone/pull/3062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a change in pull request #3062: HDDS-6259. EC: Pipelines for closed containers should contain correct replica indexes
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on a change in pull request #3062:
URL: https://github.com/apache/ozone/pull/3062#discussion_r803879546
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
##########
@@ -256,12 +256,9 @@ private ContainerWithPipeline getContainerWithPipelineCommon(
}
if (pipeline == null) {
Review comment:
I think it's not safe design to pass the COntainerReplicas directly to pluggable pipeline creator classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a change in pull request #3062: HDDS-6259. EC: Pipelines for closed containers should contain correct replica indexes
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on a change in pull request #3062:
URL: https://github.com/apache/ozone/pull/3062#discussion_r803957772
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
##########
@@ -256,12 +256,9 @@ private ContainerWithPipeline getContainerWithPipelineCommon(
}
if (pipeline == null) {
Review comment:
Yes. But I see your PR discussing the fundamental issue of that. Since we track down that in master, we can ahead with this change here. Post that PR, I assume that will be a separate set than original one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a change in pull request #3062: HDDS-6259. EC: Pipelines for closed containers should contain correct replica indexes
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #3062:
URL: https://github.com/apache/ozone/pull/3062#discussion_r803898055
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
##########
@@ -256,12 +256,9 @@ private ContainerWithPipeline getContainerWithPipelineCommon(
}
if (pipeline == null) {
Review comment:
For what reason? Is it because the replicas are mutable right now? If so, there is already a PR to fix that on master #3071, as it is a wider problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org