You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/01/18 23:15:19 UTC
[GitHub] [sling-slingfeature-maven-plugin] enapps-enorman opened a new pull request #67: SLING-10069 The generated features target dir is created in the wrong place
enapps-enorman opened a new pull request #67:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/67
After switching to the 1.4.22 release version of the plugin, I noticed that the change for SLING-10035 appears to be creating a set of empty folders in the wrong place in my linux environment.
Using a debugger, I see that the targetDir File object is constructed at AbstractFeatureMojo line 244 with the "child" second argument already resolved to be an absolute path. This appears to append the absolute child path to the parent path rather than checking if "child" is relative or absolute to resolve it.
Expect the targetDir resolution to properly resolve the path when the child is an absolute path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] enapps-enorman merged pull request #67: SLING-10069 The generated features target dir is created in the wrong place
Posted by GitBox <gi...@apache.org>.
enapps-enorman merged pull request #67:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/67
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #67: SLING-10069 The generated features target dir is created in the wrong place
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #67:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/67#issuecomment-762512824
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='70.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&metric=new_coverage&view=list) [70.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin&pullRequest=67&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] bosschaert commented on pull request #67: SLING-10069 The generated features target dir is created in the wrong place
Posted by GitBox <gi...@apache.org>.
bosschaert commented on pull request #67:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/67#issuecomment-762712264
@schaefa maybe you can take a look at this PR as it seems that your change for SLING-10035 caused this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-slingfeature-maven-plugin] enapps-enorman merged pull request #67: SLING-10069 The generated features target dir is created in the wrong place
Posted by GitBox <gi...@apache.org>.
enapps-enorman merged pull request #67:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/67
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org