You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2007/01/12 12:43:27 UTC

[jira] Commented: (HARMONY-1776) [classlib][swing]javax.swing.plaf.basic.BasicTableUI.paint(null, JComponent) does not throw unspecified NPE

    [ https://issues.apache.org/jira/browse/HARMONY-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464184 ] 

Mark Hindess commented on HARMONY-1776:
---------------------------------------

Vasily, thanks for the patches.  I've applied your fix and test patches in r495558.  I've not applied the make patch because testPaint fails with:

java.lang.UnsatisfiedLinkError: org/apache/harmony/awt/gl/font/
      LinuxNativeFont.NativeFreeGlyphBitmap(J)V at
      org.apache.harmony.awt.gl.font.LinuxGlyph.initFTBitmap
      (LinuxGlyph.java:178) at
      org.apache.harmony.awt.gl.font.LinuxGlyph.getBitmap
      (LinuxGlyph.java:151) at ...

Nikolay, please confirm that this resolves your issue.


> [classlib][swing]javax.swing.plaf.basic.BasicTableUI.paint(null, JComponent) does not throw unspecified  NPE
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1776
>                 URL: https://issues.apache.org/jira/browse/HARMONY-1776
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Nikolay Bannikov
>            Priority: Minor
>         Attachments: Harmony-1776-Make.patch, Harmony-1776-Test.patch, Harmony-1776.patch
>
>
> RI of javax.swing.plaf.basic.BasicTableUI.paint(null,JComponent) throws unspecified NPE while Harmony implementation of the method works silently.
> Test for reproducing:
> import junit.framework.TestCase;
> import javax.swing.JSpinner;
> import javax.swing.JTable;
> import javax.swing.plaf.basic.BasicTableUI;
> public class Test extends TestCase {       
>       public void testBasicTableUI_paint_Graphics_JComponent() { 
>             BasicTableUI b = new BasicTableUI();
>             b.installUI(new JTable());
>             try {
>                   b.paint(null, new JSpinner());
>                   fail("NPE should be thrown");
>             } catch ( NullPointerException e) {
>                   //expected 
>             }
>       }
> }
> HARMONY output:
> =============
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r450941, (Sep 28 2006), Windows/ia32/msvc 1310, release build
> http://incubator.apache.org/harmony
> .F
> Time: 2.141
> There was 1 failure:
> 1) testBasicTableUI_paint_Graphics_JComponent(Test)junit.framework.AssertionFailedError: NPE should be thrown
>         at Test.testBasicTableUI_paint_Graphics_JComponent(Test.java:13)
>         at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> SUN output:
> ========
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .
> Time: 0.656
> OK (1 test)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira