You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Brandon Ehle <az...@yahoo.com> on 2002/12/03 19:16:23 UTC
[PATCH] (2) Improve performance of svn_time_from_cstring
Greg Hudson wrote:
>If there's no measurable benefit from using fast_strtoul10, I'd prefer
>using the real strtoul() for conciseness. (And there definitely doesn't
>need to be a commented-out strtoui10 there.) As has been pointed out
>beofre, there's no real portability issue here.
>
>And you need a log message, as documented in HACKING.
>
>
* subversion/libsvn_subr/time.c (svn_time_from_cstring): Replace sscanf
with strtoul for better performance.
Re: [PATCH] (2) Improve performance of svn_time_from_cstring
Posted by Branko Čibej <br...@xbc.nu>.
Brandon Ehle wrote:
> Sorry, didn't notice that, my editor auto-corrected that style.
Heh, the correct term here is "auto-corrupted". :-)
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] (2) Improve performance of svn_time_from_cstring
Posted by Brandon Ehle <az...@yahoo.com>.
>
>
>>- exploded_time.tm_wday = find_matching_string (wday, 7, apr_day_snames);
>>- exploded_time.tm_mon = find_matching_string (month, 12, apr_month_snames);
>>+ exploded_time.tm_wday = find_matching_string(wday, 7, apr_day_snames);
>>+ exploded_time.tm_mon = find_matching_string(month, 12, apr_month_snames);
>>
>>
>>
>You're changing the formatting style here. Please don't do that. The
>rules are: 1) Follow the style the rest of the file uses, and 2) Don't
>mix formatting-only changes with functional changes.
>
>
Sorry, didn't notice that, my editor auto-corrected that style.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] (2) Improve performance of svn_time_from_cstring
Posted by Branko Čibej <br...@xbc.nu>.
Brandon Ehle wrote:
> * subversion/libsvn_subr/time.c (svn_time_from_cstring): Replace
> sscanf with strtoul for better performance.
[snip]
>- exploded_time.tm_wday = find_matching_string (wday, 7, apr_day_snames);
>- exploded_time.tm_mon = find_matching_string (month, 12, apr_month_snames);
>+ exploded_time.tm_wday = find_matching_string(wday, 7, apr_day_snames);
>+ exploded_time.tm_mon = find_matching_string(month, 12, apr_month_snames);
>
You're changing the formatting style here. Please don't do that. The
rules are: 1) Follow the style the rest of the file uses, and 2) Don't
mix formatting-only changes with functional changes.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org