You are viewing a plain text version of this content. The canonical link for it is here.
Posted to photark-dev@incubator.apache.org by "Avdhesh Yadav (JIRA)" <ji...@apache.org> on 2010/04/08 13:00:36 UTC
[jira] Created: (PHOTARK-28) Search and Tagging Functionality
Search and Tagging Functionality
--------------------------------
Key: PHOTARK-28
URL: https://issues.apache.org/jira/browse/PHOTARK-28
Project: PhotArk
Issue Type: New Feature
Affects Versions: PhotArk M1
Reporter: Avdhesh Yadav
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PHOTARK-28) Search and Tagging Functionality
Posted by "Avdhesh Yadav (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avdhesh Yadav resolved PHOTARK-28.
----------------------------------
Resolution: Fixed
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch, photark_28_phillipe_ramalho_08_13_2010.patch, photark_28_phillipe_ramalho_08_14_2010.patch, photark_28_phillipe_ramalho_08_14_2010_remove_logging.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-28) Search and Tagging Functionality
Posted by "Phillipe Ramalho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883039#action_12883039 ]
Phillipe Ramalho commented on PHOTARK-28:
-----------------------------------------
Thanks Luciano for applying the patches ;)
The search queries below should work fine:
album:vegas
album:vegas
album:*
name:dsc*
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-28) Search and Tagging Functionality
Posted by "Phillipe Ramalho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phillipe Ramalho updated PHOTARK-28:
------------------------------------
Attachment: photark_28_phillipe_ramalho_06_13_2010.patch
These are the latest changes on search functionality, the main changes are:
- Gallery is now invoking the search component using the listener interface to index images
- Image and ImageMetadata are now serializable, so they can be passed as parameter through SCA runtime
- There is a small fix on JCRRepositoryManger, which was not being destroyed correctly when a problem occurs during its initialization
- search component was updated to use lucene 2.4.1. instead of 3.0.1, once jackrabbit is already using 2.4.1 and I was getting conflicts when I added 3.0.1 to the classpath
Next step: start working on the UI
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-28) Search and Tagging Functionality
Posted by "Phillipe Ramalho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phillipe Ramalho updated PHOTARK-28:
------------------------------------
Attachment: photark_28_phillipe_ramalho_06_21_2010.patch
Hi,
Here is my latest patch, it contains:
-all changes from the last two patches
-photark-ui contains now a search field, where users can type searches like album:boston...there is no default field defined yet, so simply typing boston or a image name should return an empty result set
-there is a workaround on how JCRGallery notifies the search component about the images contained in the war, it should be changed soon
-some unused/useless was removed, mainly from gallery.html
Work still in progress, specially on how the results are displayed
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-28) Search and Tagging Functionality
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882908#action_12882908 ]
Luciano Resende commented on PHOTARK-28:
----------------------------------------
Patches applied under svn r958317
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-28) Search and Tagging Functionality
Posted by "Avdhesh Yadav (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898227#action_12898227 ]
Avdhesh Yadav commented on PHOTARK-28:
--------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Compilation failure
/opt/projects/opensource/photark/trunk/photark-search/src/main/java/org/apache/photark/search/services/SearchService.java:[13,4] cannot find symbol
symbol : class ImageTags
location: interface org.apache.photark.search.services.SearchService
/opt/projects/opensource/photark/trunk/photark-search/src/main/java/org/apache/photark/search/services/impl/SearchServiceImpl.java:[36,41] cannot find symbol
symbol : class ImageTags
location: package org.apache.photark.search.services
/opt/projects/opensource/photark/trunk/photark-search/src/main/java/org/apache/photark/search/services/impl/SearchServiceImpl.java:[307,11] cannot find symbol
symbol : class ImageTags
location: class org.apache.photark.search.services.impl.SearchServiceImpl
/opt/projects/opensource/photark/trunk/photark-search/src/main/java/org/apache/photark/search/services/impl/SearchServiceImpl.java:[315,27] cannot find symbol
symbol : class ImageTagsImpl
location: class org.apache.photark.search.services.impl.SearchServiceImpl
/opt/projects/opensource/photark/trunk/photark-search/src/main/java/org/apache/photark/search/services/impl/SearchServiceImpl.java:[323,19] cannot find symbol
symbol : class ImageTagsImpl
location: class org.apache.photark.search.services.impl.SearchServiceImpl
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21 seconds
[INFO] Finished at: Fri Aug 13 18:50:46 IST 2010
[INFO] Final Memory: 45M/109M
[INFO] ------------------------------------------------------------------------
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch, photark_28_phillipe_ramalho_08_13_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-28) Search and Tagging Functionality
Posted by "Phillipe Ramalho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876589#action_12876589 ]
Phillipe Ramalho commented on PHOTARK-28:
-----------------------------------------
Hi Avdhesh,
I was just following the naming conventions used in Java for listeners, like the one used in ActionListener [1] and many other listeners included in the JDK.
[1] - http://java.sun.com/docs/books/tutorial/uiswing/events/intro.html
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-28) Search and Tagging Functionality
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882907#action_12882907 ]
Luciano Resende commented on PHOTARK-28:
----------------------------------------
Do you have a search sample I could use ?
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-28) Search and Tagging Functionality
Posted by "Phillipe Ramalho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phillipe Ramalho updated PHOTARK-28:
------------------------------------
Attachment: photark_28_phillipe_ramalho_08_14_2010_remove_logging.patch
Hi Luciano,
Thanks for applying the patch and noticing the logging information I forgot to remove. Here is the new patch that cleans up print calls from the code
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch, photark_28_phillipe_ramalho_08_13_2010.patch, photark_28_phillipe_ramalho_08_14_2010.patch, photark_28_phillipe_ramalho_08_14_2010_remove_logging.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-28) Search and Tagging Functionality
Posted by "Phillipe Ramalho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phillipe Ramalho updated PHOTARK-28:
------------------------------------
Attachment: photark_28_phillipe_ramalho_06_06_2010.patch
Here is my first patch. It includes the basic code for indexing, which is located in a new component: photark-search.
It's still not working, since the albums are not invoking yet the search component to index the new images, this will be the next step.
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-28) Search and Tagging Functionality
Posted by "Phillipe Ramalho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phillipe Ramalho updated PHOTARK-28:
------------------------------------
Attachment: photark_28_phillipe_ramalho_08_14_2010.patch
Sorry Avdhesh, I forgot to add these two files to the patch, here is the new patch containing the missing files
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch, photark_28_phillipe_ramalho_08_13_2010.patch, photark_28_phillipe_ramalho_08_14_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-28) Search and Tagging Functionality
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898613#action_12898613 ]
Luciano Resende commented on PHOTARK-28:
----------------------------------------
Patch applied, it would be good to cleanup some of the console/log outputs to at least have some meaningful information being output if any. See example below :
termmmmmmmmmmmmmmmmmsssssss
album:boston
album:vegas
date_posted:201007031420
date_posted:201007031554
id:boston/dsc00368.jpg
id:boston/dsc00369.jpg
id:boston/dsc00370.jpg
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch, photark_28_phillipe_ramalho_08_13_2010.patch, photark_28_phillipe_ramalho_08_14_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PHOTARK-28) Search and Tagging Functionality
Posted by "Phillipe Ramalho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phillipe Ramalho updated PHOTARK-28:
------------------------------------
Attachment: photark_28_phillipe_ramalho_08_13_2010.patch
This patch includes:
-backend for image tagging
-tagging is also implemented in the UI, where the user can add, search and remove tags from pictures
-search results are now displayed in a table layout
-if no field is defined in the query string, the query will be executed against all these fields: "tag", "name" and "album"
-when the user clicks on a search result, he is redirected directly to the album and the selected picture result is set as current album image
Still remainds:
-the search results should display the picture miniature instead of just text, it can be easily implemented later when an API for retrieving picture miniatures becomes available
-the tag remove button should be an image button, something like an X...today it's just the text "remove"
-improve the add tag text field and button
-more documentation on the search service API
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch, photark_28_phillipe_ramalho_08_13_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-28) Search and Tagging Functionality
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898656#action_12898656 ]
Luciano Resende commented on PHOTARK-28:
----------------------------------------
Patch applied. Thanks for the quick turnaround.
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch, photark_28_phillipe_ramalho_08_13_2010.patch, photark_28_phillipe_ramalho_08_14_2010.patch, photark_28_phillipe_ramalho_08_14_2010_remove_logging.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PHOTARK-28) Search and Tagging Functionality
Posted by "Avdhesh Yadav (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876283#action_12876283 ]
Avdhesh Yadav commented on PHOTARK-28:
--------------------------------------
Great to see your first patch !!!
Comments
minor improvement in the naming of the methods of GalleryListener interface.
imageAdded(Image image); should be onImageAdded(Image image);
similarly
imageAdded(Image image); should be onImageAdded(Image image);
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PHOTARK-28) Search and Tagging Functionality
Posted by "Luciano Resende (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PHOTARK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luciano Resende reassigned PHOTARK-28:
--------------------------------------
Assignee: Phillipe Ramalho
> Search and Tagging Functionality
> --------------------------------
>
> Key: PHOTARK-28
> URL: https://issues.apache.org/jira/browse/PHOTARK-28
> Project: PhotArk
> Issue Type: New Feature
> Affects Versions: PhotArk M3
> Reporter: Avdhesh Yadav
> Assignee: Phillipe Ramalho
> Fix For: PhotArk M3
>
> Attachments: photark_28_phillipe_ramalho_06_06_2010.patch, photark_28_phillipe_ramalho_06_13_2010.patch, photark_28_phillipe_ramalho_06_21_2010.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.