You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "anxkhn (via GitHub)" <gi...@apache.org> on 2026/07/06 12:32:58 UTC
[PR] Fix typo in Pig aggregate UDF exception message [calcite]
anxkhn opened a new pull request, #5083:
URL: https://github.com/apache/calcite/pull/5083
## Jira Link
Not applicable. Per the PR template, a Jira issue is not required for typos and
cosmetic changes (changes that are neither bugs nor features). This PR only
corrects a misspelled word in a user-facing exception message; there is no
functional change.
## Changes Proposed
Fixes a typo in the `UnsupportedOperationException` message thrown by
`PigRelUdfConverter.getSqlAggFuncForPigUdf`. The word "aggegate" was a
misspelling of "aggregate".
`piglet/src/main/java/org/apache/calcite/piglet/PigRelUdfConverter.java`:
```diff
- "Cannot find corresponding SqlAgg func for Pig aggegate " + pigUdfClassName);
+ "Cannot find corresponding SqlAgg func for Pig aggregate " + pigUdfClassName);
```
This message is surfaced to the user when a Pig `Accumulator` UDF has no built-in
SQL aggregate equivalent. The corrected spelling also matches the method's own
Javadoc, which already refers to the "Pig aggregate UDF call".
No behavior changes and no new tests: the message string is not matched or parsed
anywhere in the codebase, so this is a message-only correction. Validated locally
with `./gradlew :piglet:autostyleCheck :piglet:checkstyleMain :piglet:compileJava`
and `./gradlew :core:test --tests "*.LintTest.testLintLog" --tests
"*.LintTest.testLogMatcher"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typo in Pig aggregate UDF exception message [calcite]
Posted by "anxkhn (via GitHub)" <gi...@apache.org>.
anxkhn commented on PR #5083:
URL: https://github.com/apache/calcite/pull/5083#issuecomment-4895346499
Thank you @mihaibudiu
I was super confused what to use as it was git convention to use fix, but your suggestion is helpful. Super thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typo in Pig aggregate UDF exception message [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #5083:
URL: https://github.com/apache/calcite/pull/5083#issuecomment-4895305648
There is a linter rule which rejects commit messages starting with "Fix", but it didn't seem to be upset by your change. But maybe you can replace "Fix" with "Correct"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct typo in Pig aggregate UDF exception message [calcite]
Posted by "anxkhn (via GitHub)" <gi...@apache.org>.
anxkhn commented on PR #5083:
URL: https://github.com/apache/calcite/pull/5083#issuecomment-4900451130
Superseded by #5084, which now consolidates this typo correction with the other related exception-message typo corrections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct typo in Pig aggregate UDF exception message [calcite]
Posted by "anxkhn (via GitHub)" <gi...@apache.org>.
anxkhn closed pull request #5083: Correct typo in Pig aggregate UDF exception message
URL: https://github.com/apache/calcite/pull/5083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct typo in Pig aggregate UDF exception message [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #5083:
URL: https://github.com/apache/calcite/pull/5083#issuecomment-4898422456
Please note that your commit message also needs to be updated; the first letter must be capitalized. The same applies to other PRs—simply changing the PR title is not enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typo in Pig aggregate UDF exception message [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #5083:
URL: https://github.com/apache/calcite/pull/5083#issuecomment-4892977247
Avoid using "Fix" in titles and commit messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix typo in Pig aggregate UDF exception message [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5083:
URL: https://github.com/apache/calcite/pull/5083#issuecomment-4893068250
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5083) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5083&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5083&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5083&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5083&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5083&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5083)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org