You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by ah...@apache.org on 2017/01/08 05:41:43 UTC

zeppelin git commit: [ZEPPELIN-1908] Invalid Typo Method name

Repository: zeppelin
Updated Branches:
  refs/heads/master b7ffb0693 -> e7484fcda


[ZEPPELIN-1908] Invalid Typo Method name

### What is this PR for?
Invalid Typo Method name

closeAndRmoveAllInterpreterGroups -> closeAndRemoveAllInterpreterGroups

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1908

### Questions: no
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: cloverhearts <cl...@gmail.com>

Closes #1851 from cloverhearts/ZEPPELIN-1908 and squashes the following commits:

e8de6f8 [cloverhearts] add fixed typo
0d2bbca [cloverhearts] fixed method typo


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/e7484fcd
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/e7484fcd
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/e7484fcd

Branch: refs/heads/master
Commit: e7484fcda4eecaee26bc86cf84b2b0bc00a81403
Parents: b7ffb06
Author: cloverhearts <cl...@gmail.com>
Authored: Thu Jan 5 05:11:50 2017 -0800
Committer: ahyoungryu <ah...@apache.org>
Committed: Sun Jan 8 14:41:33 2017 +0900

----------------------------------------------------------------------
 .../org/apache/zeppelin/interpreter/InterpreterFactory.java  | 8 ++++----
 .../org/apache/zeppelin/interpreter/InterpreterSetting.java  | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/e7484fcd/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
index f13a106..1f52e3c 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
@@ -825,7 +825,7 @@ public class InterpreterFactory implements InterpreterGroupFactory {
     synchronized (interpreterSettings) {
       if (interpreterSettings.containsKey(id)) {
         InterpreterSetting intp = interpreterSettings.get(id);
-        intp.closeAndRmoveAllInterpreterGroups();
+        intp.closeAndRemoveAllInterpreterGroups();
 
         interpreterSettings.remove(id);
         for (List<String> settings : interpreterBindings.values()) {
@@ -954,7 +954,7 @@ public class InterpreterFactory implements InterpreterGroupFactory {
         try {
           stopJobAllInterpreter(intpSetting);
 
-          intpSetting.closeAndRmoveAllInterpreterGroups();
+          intpSetting.closeAndRemoveAllInterpreterGroups();
           intpSetting.setOption(option);
           intpSetting.setProperties(properties);
           intpSetting.setDependencies(dependencies);
@@ -999,7 +999,7 @@ public class InterpreterFactory implements InterpreterGroupFactory {
 
         stopJobAllInterpreter(intpSetting);
 
-        intpSetting.closeAndRmoveAllInterpreterGroups();
+        intpSetting.closeAndRemoveAllInterpreterGroups();
 
       } else {
         throw new InterpreterException("Interpreter setting id " + id + " not found");
@@ -1035,7 +1035,7 @@ public class InterpreterFactory implements InterpreterGroupFactory {
       for (final InterpreterSetting intpSetting : intpSettings) {
         Thread t = new Thread() {
           public void run() {
-            intpSetting.closeAndRmoveAllInterpreterGroups();
+            intpSetting.closeAndRemoveAllInterpreterGroups();
           }
         };
         t.start();

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/e7484fcd/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
index 2ebc6ef..9532cd1 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSetting.java
@@ -190,7 +190,7 @@ public class InterpreterSetting {
     }
   }
 
-  void closeAndRmoveAllInterpreterGroups() {
+  void closeAndRemoveAllInterpreterGroups() {
     HashSet<String> groupsToRemove = new HashSet<>(interpreterGroupRef.keySet());
     for (String key : groupsToRemove) {
       closeAndRemoveInterpreterGroup(key);