You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Marcel Kinard <cm...@gmail.com> on 2012/12/07 20:43:23 UTC
pull request for coho
I just submitted a pull request:
https://github.com/apache/incubator-cordova-coho/pull/3
- add wp8 content
- remove 'incubator' from the repo names
- rename 'webworks' from the blackberry repo name
- add changelog entries for docs, js, mobile-spec, hello-world
- fix changelog generation when selecting a subset of platforms
@stevengill, could take a look and merge this in?
I also noticed that the DISCLAIMER still has verbage about being an
incubator project, but I didn't update that.
-- Marcel Kinard
Re: pull request for coho
Posted by Marcel Kinard <cm...@gmail.com>.
Thanks for your publish.
I think I found an issue in your updates. I opened CB-2108 and have a
pull request for you to merge if you like it.
-- Marcel
On 12/30/2012 4:04 PM, Steven Gill wrote:
> Sorry about that Marcel! I went away for the holidays. I pushed my changes
> to the repo.
>
> Cheers,
> -Steve
>
> On Wed, Dec 19, 2012 at 12:43 PM, Marcel Kinard <cm...@gmail.com> wrote:
>
>> Steve, could you push out your coho changes to the repo? I don't see them
>> yet.
>>
>> Then I could merge in your changes and re-do the pull request. Thanks!
>>
>> -- Marcel
>>
>>
>> On 12/12/2012 4:06 PM, Steven Gill wrote:
>>
>>> Hey Marcel,
>>>
>>> I have already made some of these changes for the rc1 release. I must have
>>> forgot to push the changes to the apache repo. I will do that and review
>>> your push request to see if I missed anything.
>>>
>>> Cheers,
>>> -Steve
>>>
>>> On Wed, Dec 12, 2012 at 10:03 AM, Marcel Kinard <cm...@gmail.com>
>>> wrote:
>>>
>>> I've resubmitted this as https://github.com/apache/****
>>>> cordova-coho/pull/1 <https://github.com/apache/**cordova-coho/pull/1><
>>>> https://**github.com/apache/cordova-**coho/pull/1<https://github.com/apache/cordova-coho/pull/1>>since
>>>> the incubator github repo is now gone.
>>>>
>>>>
>>>> Steven, I think you'll want this for 2.3.0.
>>>>
>>>> -- Marcel Kinard
>>>>
>>>>
>>>> On 12/7/2012 2:43 PM, Marcel Kinard wrote:
>>>>
>>>> I just submitted a pull request: https://github.com/apache/**
>>>>> incubator-cordova-coho/pull/3<**https://github.com/apache/**
>>>>> incubator-cordova-coho/pull/3<https://github.com/apache/incubator-cordova-coho/pull/3>
>>>>>
>>>>> - add wp8 content
>>>>> - remove 'incubator' from the repo names
>>>>> - rename 'webworks' from the blackberry repo name
>>>>> - add changelog entries for docs, js, mobile-spec, hello-world
>>>>> - fix changelog generation when selecting a subset of platforms
>>>>>
>>>>> @stevengill, could you take a look and merge this in?
>>>>>
>>>>>
>>>>> I also noticed that the DISCLAIMER still has verbage about being an
>>>>> incubator project, but I didn't update that.
>>>>>
>>>>> -- Marcel Kinard
>>>>>
>>>>>
>>>>>
>>>>>
Re: pull request for coho
Posted by Steven Gill <st...@gmail.com>.
Sorry about that Marcel! I went away for the holidays. I pushed my changes
to the repo.
Cheers,
-Steve
On Wed, Dec 19, 2012 at 12:43 PM, Marcel Kinard <cm...@gmail.com> wrote:
> Steve, could you push out your coho changes to the repo? I don't see them
> yet.
>
> Then I could merge in your changes and re-do the pull request. Thanks!
>
> -- Marcel
>
>
> On 12/12/2012 4:06 PM, Steven Gill wrote:
>
>> Hey Marcel,
>>
>> I have already made some of these changes for the rc1 release. I must have
>> forgot to push the changes to the apache repo. I will do that and review
>> your push request to see if I missed anything.
>>
>> Cheers,
>> -Steve
>>
>> On Wed, Dec 12, 2012 at 10:03 AM, Marcel Kinard <cm...@gmail.com>
>> wrote:
>>
>> I've resubmitted this as https://github.com/apache/****
>>> cordova-coho/pull/1 <https://github.com/apache/**cordova-coho/pull/1><
>>> https://**github.com/apache/cordova-**coho/pull/1<https://github.com/apache/cordova-coho/pull/1>>since
>>> the incubator github repo is now gone.
>>>
>>>
>>> Steven, I think you'll want this for 2.3.0.
>>>
>>> -- Marcel Kinard
>>>
>>>
>>> On 12/7/2012 2:43 PM, Marcel Kinard wrote:
>>>
>>> I just submitted a pull request: https://github.com/apache/**
>>>> incubator-cordova-coho/pull/3<**https://github.com/apache/**
>>>> incubator-cordova-coho/pull/3<https://github.com/apache/incubator-cordova-coho/pull/3>
>>>> >
>>>>
>>>>
>>>> - add wp8 content
>>>> - remove 'incubator' from the repo names
>>>> - rename 'webworks' from the blackberry repo name
>>>> - add changelog entries for docs, js, mobile-spec, hello-world
>>>> - fix changelog generation when selecting a subset of platforms
>>>>
>>>> @stevengill, could you take a look and merge this in?
>>>>
>>>>
>>>> I also noticed that the DISCLAIMER still has verbage about being an
>>>> incubator project, but I didn't update that.
>>>>
>>>> -- Marcel Kinard
>>>>
>>>>
>>>>
>>>>
>
Re: pull request for coho
Posted by Marcel Kinard <cm...@gmail.com>.
Steve, could you push out your coho changes to the repo? I don't see
them yet.
Then I could merge in your changes and re-do the pull request. Thanks!
-- Marcel
On 12/12/2012 4:06 PM, Steven Gill wrote:
> Hey Marcel,
>
> I have already made some of these changes for the rc1 release. I must have
> forgot to push the changes to the apache repo. I will do that and review
> your push request to see if I missed anything.
>
> Cheers,
> -Steve
>
> On Wed, Dec 12, 2012 at 10:03 AM, Marcel Kinard <cm...@gmail.com> wrote:
>
>> I've resubmitted this as https://github.com/apache/**cordova-coho/pull/1<https://github.com/apache/cordova-coho/pull/1>since the incubator github repo is now gone.
>>
>> Steven, I think you'll want this for 2.3.0.
>>
>> -- Marcel Kinard
>>
>>
>> On 12/7/2012 2:43 PM, Marcel Kinard wrote:
>>
>>> I just submitted a pull request: https://github.com/apache/**
>>> incubator-cordova-coho/pull/3<https://github.com/apache/incubator-cordova-coho/pull/3>
>>>
>>> - add wp8 content
>>> - remove 'incubator' from the repo names
>>> - rename 'webworks' from the blackberry repo name
>>> - add changelog entries for docs, js, mobile-spec, hello-world
>>> - fix changelog generation when selecting a subset of platforms
>>>
>>> @stevengill, could you take a look and merge this in?
>>>
>>>
>>> I also noticed that the DISCLAIMER still has verbage about being an
>>> incubator project, but I didn't update that.
>>>
>>> -- Marcel Kinard
>>>
>>>
>>>
Re: pull request for coho
Posted by Steven Gill <st...@gmail.com>.
Hey Marcel,
I have already made some of these changes for the rc1 release. I must have
forgot to push the changes to the apache repo. I will do that and review
your push request to see if I missed anything.
Cheers,
-Steve
On Wed, Dec 12, 2012 at 10:03 AM, Marcel Kinard <cm...@gmail.com> wrote:
> I've resubmitted this as https://github.com/apache/**cordova-coho/pull/1<https://github.com/apache/cordova-coho/pull/1>since the incubator github repo is now gone.
>
> Steven, I think you'll want this for 2.3.0.
>
> -- Marcel Kinard
>
>
> On 12/7/2012 2:43 PM, Marcel Kinard wrote:
>
>> I just submitted a pull request: https://github.com/apache/**
>> incubator-cordova-coho/pull/3<https://github.com/apache/incubator-cordova-coho/pull/3>
>>
>> - add wp8 content
>> - remove 'incubator' from the repo names
>> - rename 'webworks' from the blackberry repo name
>> - add changelog entries for docs, js, mobile-spec, hello-world
>> - fix changelog generation when selecting a subset of platforms
>>
>> @stevengill, could you take a look and merge this in?
>>
>>
>> I also noticed that the DISCLAIMER still has verbage about being an
>> incubator project, but I didn't update that.
>>
>> -- Marcel Kinard
>>
>>
>>
>
Re: pull request for coho
Posted by Marcel Kinard <cm...@gmail.com>.
I've resubmitted this as https://github.com/apache/cordova-coho/pull/1
since the incubator github repo is now gone.
Steven, I think you'll want this for 2.3.0.
-- Marcel Kinard
On 12/7/2012 2:43 PM, Marcel Kinard wrote:
> I just submitted a pull request:
> https://github.com/apache/incubator-cordova-coho/pull/3
>
> - add wp8 content
> - remove 'incubator' from the repo names
> - rename 'webworks' from the blackberry repo name
> - add changelog entries for docs, js, mobile-spec, hello-world
> - fix changelog generation when selecting a subset of platforms
>
> @stevengill, could you take a look and merge this in?
>
> I also noticed that the DISCLAIMER still has verbage about being an
> incubator project, but I didn't update that.
>
> -- Marcel Kinard
>
>