You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by littleseven <gi...@git.apache.org> on 2017/04/06 09:32:20 UTC

[GitHub] incubator-weex pull request #224: add a member in WXComponent to flag the co...

GitHub user littleseven opened a pull request:

    https://github.com/apache/incubator-weex/pull/224

    add a member in WXComponent to flag the component have no view

        commonly component always has a host view, but some times maybe not,
        such as a svg label, the sub component like defs will not have a
        hostview, infact, the ellipse has no view too, it just tell us need to
        draw a ellipse to it's parent compoent's hostview.
        
        example:
        
        <svg width="100%" height="100%" version="1.1"
        xmlns="http://www.w3.org/2000/svg">
        
        <defs>
        <linearGradient id="orange_red" x1="0%" y1="0%" x2="100%" y2="0%">
        <stop offset="0%" style="stop-color:rgb(255,255,0);
        stop-opacity:1"/>
        <stop offset="100%" style="stop-color:rgb(255,0,0);
        stop-opacity:1"/>
        </linearGradient>
        </defs>
        
        <ellipse cx="200" cy="190" rx="85" ry="55"
        style="fill:url(#orange_red)"/>
        
        </svg>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/littleseven/incubator-weex 0.12-dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #224
    
----
commit babfa411709212973e1bb4f2807f692ff0e174b9
Author: littleseven <70...@qq.com>
Date:   2017-04-06T08:44:39Z

    add a member in WXComponent to flag the component have no view
    
    commonly component always has a host view, but some times maybe not,
    such as a svg label, the sub component like defs will not have a
    hostview, infact, the ellipse has no view too, it just tell us need to
    draw a ellipse to it's parent compoent's hostview.
    
    example:
    
    <svg width="100%" height="100%" version="1.1"
    xmlns="http://www.w3.org/2000/svg">
    
    <defs>
    <linearGradient id="orange_red" x1="0%" y1="0%" x2="100%" y2="0%">
    <stop offset="0%" style="stop-color:rgb(255,255,0);
    stop-opacity:1"/>
    <stop offset="100%" style="stop-color:rgb(255,0,0);
    stop-opacity:1"/>
    </linearGradient>
    </defs>
    
    <ellipse cx="200" cy="190" rx="85" ry="55"
    style="fill:url(#orange_red)"/>
    
    </svg>

commit ebb1b0e91f268f99edd30383f3290b823584e330
Author: yangshengtao <ya...@163.com>
Date:   2017-04-06T09:02:47Z

    add the component type, when the node is virtual node, prohibit to create view and update view

commit e48236900f82c6952501ce3f3a28b23099dfb328
Author: \u535c\u9053 <70...@qq.com>
Date:   2017-04-06T09:30:20Z

    Merge pull request #1 from yangshengtao/0.12-dev
    
    add the component type, when the node is virtual node

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #224: add a member in WXComponent to flag the co...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/224


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---