You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jfrazee <gi...@git.apache.org> on 2016/09/13 15:26:43 UTC
[GitHub] nifi pull request #1015: NIFI-2767 Periodically reload properties from file-...
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1015
NIFI-2767 Periodically reload properties from file-based variable registry properties files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jfrazee/nifi NIFI-2767
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1015.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1015
----
commit 62ca8d2b2eb3bf71b83597eac80481d1b5539043
Author: Joey Frazee <jo...@icloud.com>
Date: 2016-09-13T15:00:13Z
NIFI-2767 Periodically reload properties from file-based variable registry properties files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1015: NIFI-2767 Periodically reload properties from file-based v...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1015
@jfrazee if this is still something you'd like to pursue can you rebase. I can work with you on it. Not sure about lifecycle implications of this sort of thing though. So long as it is only the var reg values being reloaded then it is probably fair game.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1015: NIFI-2767 Periodically reload properties from file-based v...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1015
Hey @jfrazee - I think we can close this PR with the new feature to define variables at Process Group level through the UI.
---
[GitHub] nifi issue #1015: NIFI-2767 Periodically reload properties from file-based v...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1015
@jfrazee any chance of rebasing this?
Keen to revisit this PR and get the review going, otherwise happy for you to close it as well.
Cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1015: NIFI-2767 Periodically reload properties from file-based v...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1015
@trixpan Just rebased it again. Made some minor changes: using MD5SumMonitor with the watcher now because the last modified monitor wasn't reliably testable, setting the check schedule to 0 disables it, and cleaned up the tests.
In the JIRA the question of whether this was safe was brought up. From the standpoint of will reloading the map in the FileBasedVariableRegistry break anything core, I think the answer is no (it's only used in EL value lookups), so, assuming I didn't make anything too buggy, it's safe in that respect. From the standpoint of will it be possible to build flows that don't behave like the author was expecting if they expected stuff to be static, the answer is probably yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---