You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2011/10/03 17:01:39 UTC
Review Request: Potential test failure in GadgetHandlerTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2149/
-----------------------------------------------------------
Review request for shindig, Henry Saputra and Dan Dumont.
Summary
-------
GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
This addresses bug SHINDIG-1634.
https://issues.apache.org/jira/browse/SHINDIG-1634
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236
Diff: https://reviews.apache.org/r/2149/diff
Testing
-------
Ran mvn build
Thanks,
Ryan
Re: Review Request: Potential test failure in GadgetHandlerTest
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-10-03 16:07:31, Paul Lindner wrote:
> > For the future: since you're a committer and have CLA on file I'd just go ahead and submit non-feature related fixes like this directly. Less time clicking in jira == more time coding :)
> >
Thanks Paul. We would all like more time coding.
Committed revision 1178441.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2149/#review2264
-----------------------------------------------------------
On 2011-10-03 15:01:39, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2149/
> -----------------------------------------------------------
>
> (Updated 2011-10-03 15:01:39)
>
>
> Review request for shindig, Henry Saputra and Dan Dumont.
>
>
> Summary
> -------
>
> GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
>
>
> This addresses bug SHINDIG-1634.
> https://issues.apache.org/jira/browse/SHINDIG-1634
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236
>
> Diff: https://reviews.apache.org/r/2149/diff
>
>
> Testing
> -------
>
> Ran mvn build
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Potential test failure in GadgetHandlerTest
Posted by Paul Lindner <li...@inuus.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2149/#review2264
-----------------------------------------------------------
Ship it!
For the future: since you're a committer and have CLA on file I'd just go ahead and submit non-feature related fixes like this directly. Less time clicking in jira == more time coding :)
- Paul
On 2011-10-03 15:01:39, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2149/
> -----------------------------------------------------------
>
> (Updated 2011-10-03 15:01:39)
>
>
> Review request for shindig, Henry Saputra and Dan Dumont.
>
>
> Summary
> -------
>
> GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.
>
>
> This addresses bug SHINDIG-1634.
> https://issues.apache.org/jira/browse/SHINDIG-1634
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236
>
> Diff: https://reviews.apache.org/r/2149/diff
>
>
> Testing
> -------
>
> Ran mvn build
>
>
> Thanks,
>
> Ryan
>
>