You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/26 15:33:23 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #6768: Allow template names upto 255 chars
DaanHoogland opened a new pull request, #6768:
URL: https://github.com/apache/cloudstack/pull/6768
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
Fixes: #6766
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#discussion_r983310651
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1747,8 +1747,8 @@ public VMTemplateVO createPrivateTemplateRecord(CreateTemplateCmd cmd, Account t
_accountMgr.checkAccess(caller, null, true, templateOwner);
String name = cmd.getTemplateName();
- if ((name == null) || (name.length() > 32)) {
- throw new InvalidParameterValueException("Template name cannot be null and should be less than 32 characters");
+ if ((name == null) || (name.length() > 255)) {
Review Comment:
did it anyway, I didn´t implement it in the other APIs though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1259128822
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6768)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6768&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6768&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6768&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_coverage&view=list) [35.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1259073868
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1258325479
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6768)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6768&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6768&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6768&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_coverage&view=list) [38.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1258224733
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#discussion_r983188365
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1747,8 +1747,8 @@ public VMTemplateVO createPrivateTemplateRecord(CreateTemplateCmd cmd, Account t
_accountMgr.checkAccess(caller, null, true, templateOwner);
String name = cmd.getTemplateName();
- if ((name == null) || (name.length() > 32)) {
- throw new InvalidParameterValueException("Template name cannot be null and should be less than 32 characters");
+ if ((name == null) || (name.length() > 255)) {
Review Comment:
yes, but that constant would have to be used in more than just this method (also for registiring/editting of a template. That would be a bit beyond the scope of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1262110896
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1263014327
<b>Trillian test result (tid-5052)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43787 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6768-t5052-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1262081738
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#discussion_r983310651
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1747,8 +1747,8 @@ public VMTemplateVO createPrivateTemplateRecord(CreateTemplateCmd cmd, Account t
_accountMgr.checkAccess(caller, null, true, templateOwner);
String name = cmd.getTemplateName();
- if ((name == null) || (name.length() > 32)) {
- throw new InvalidParameterValueException("Template name cannot be null and should be less than 32 characters");
+ if ((name == null) || (name.length() > 255)) {
Review Comment:
did it anyway, I didn´t implement it in the there APIs though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1259164161
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1258303256
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1259955299
<b>Trillian test result (tid-5030)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38159 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6768-t5030-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1262028460
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1258225294
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1260910861
> @DaanHoogland have you checked if there are any DB constraints (see create table rules?) for the column that stores the name (now 255 chars)? If not, then let's merge this.
@rohityadavcloud for template registration 255 chars are already allowed. This limitation was only there when creating a template from a volume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1262081029
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1258447979
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6768?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6768](https://codecov.io/gh/apache/cloudstack/pull/6768?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d7104c) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/64316d513c88c4d5ba65b43ed8c85e974a767d81?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (64316d5) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.17 #6768 +/- ##
=========================================
Coverage 10.34% 10.34%
- Complexity 6610 6612 +2
=========================================
Files 2451 2451
Lines 242339 242339
Branches 37923 37923
=========================================
+ Hits 25058 25067 +9
+ Misses 214195 214184 -11
- Partials 3086 3088 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/com/cloud/template/TemplateManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6768/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3RlbXBsYXRlL1RlbXBsYXRlTWFuYWdlckltcGwuamF2YQ==) | `11.03% <0.00%> (ø)` | |
| [...cloudstack/network/contrail/model/ModelObject.java](https://codecov.io/gh/apache/cloudstack/pull/6768/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdC5qYXZh) | `33.33% <0.00%> (+4.16%)` | :arrow_up: |
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6768/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `44.23% <0.00%> (+15.38%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1259163377
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1260637072
@DaanHoogland have you checked if there are any DB constraints (see create table rules?) for the column that stores the name (now 255 chars)? If not, then let's merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1262140065
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#discussion_r980213012
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1747,7 +1747,7 @@ public VMTemplateVO createPrivateTemplateRecord(CreateTemplateCmd cmd, Account t
_accountMgr.checkAccess(caller, null, true, templateOwner);
String name = cmd.getTemplateName();
- if ((name == null) || (name.length() > 32)) {
+ if ((name == null) || (name.length() > 255)) {
throw new InvalidParameterValueException("Template name cannot be null and should be less than 32 characters");
Review Comment:
Fix the error msg to say 255 characters too - otherwise LGTM (also check any limitation in the db column, VO etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1259130573
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#discussion_r980837254
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1747,7 +1747,7 @@ public VMTemplateVO createPrivateTemplateRecord(CreateTemplateCmd cmd, Account t
_accountMgr.checkAccess(caller, null, true, templateOwner);
String name = cmd.getTemplateName();
- if ((name == null) || (name.length() > 32)) {
+ if ((name == null) || (name.length() > 255)) {
throw new InvalidParameterValueException("Template name cannot be null and should be less than 32 characters");
Review Comment:
```suggestion
throw new InvalidParameterValueException("Template name cannot be null and should be less than 255 characters");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1262037599
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1262109816
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6768)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6768&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6768&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6768&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6768&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_coverage&view=list) [40.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6768&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1261096766
Ah okay thanks for checking @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1262277222
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1262276257
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#discussion_r982775689
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1747,8 +1747,8 @@ public VMTemplateVO createPrivateTemplateRecord(CreateTemplateCmd cmd, Account t
_accountMgr.checkAccess(caller, null, true, templateOwner);
String name = cmd.getTemplateName();
- if ((name == null) || (name.length() > 32)) {
- throw new InvalidParameterValueException("Template name cannot be null and should be less than 32 characters");
+ if ((name == null) || (name.length() > 255)) {
Review Comment:
would be good to define a const ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1262027337
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6768: Allow template names upto 255 chars
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#issuecomment-1259073473
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org