You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/14 10:00:15 UTC
[GitHub] [superset] RoBYCoNTe opened a new pull request, #22112: fix: Legacy PivotTable throw undefined $
RoBYCoNTe opened a new pull request, #22112:
URL: https://github.com/apache/superset/pull/22112
### SUMMARY
Legacy PivotTable throw an invalid exception caused by missing jQuery library in to embedded template.
I just added missing script tag to avoid this problem. I know this is a legacy plugin that will be dismissed but I consider it very usefull (and graphically acceptable) and I suppose that someone else can use it too.
### TESTING INSTRUCTIONS
Add new Pivot Table in to public dashboard, try to load the dashboard outside superset and you will receive an errors in the box choosen to display the PivotTable.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] RoBYCoNTe commented on pull request #22112: fix: Legacy PivotTable throw undefined $
Posted by GitBox <gi...@apache.org>.
RoBYCoNTe commented on PR #22112:
URL: https://github.com/apache/superset/pull/22112#issuecomment-1340664208
Sorry, I've commited too many changes in one single pull request, I've to split it in two different pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] RoBYCoNTe closed pull request #22112: fix: Legacy PivotTable throw undefined $
Posted by GitBox <gi...@apache.org>.
RoBYCoNTe closed pull request #22112: fix: Legacy PivotTable throw undefined $
URL: https://github.com/apache/superset/pull/22112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org