You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/01/07 17:16:48 UTC
[GitHub] [trafficcontrol] jrushford opened a new pull request #6456: Resolves issue #6439 by changing the TM endpoint used to get cache status using publish/CrStates
jrushford opened a new pull request #6456:
URL: https://github.com/apache/trafficcontrol/pull/6456
Closes #6439 by changing the TM endpoint used to get cache status using publish/CrStates
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
- Traffic Control Health Client (tc-health-client)
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
Run the tc-health-client tests. cd tc-health-client; go test ./...
After startup, the health-client will query the TM publish/CrStates endpoint. You should not see any errors in the
log file and parent caches that are down should be marked down and then back up when they are restored.
See /var/log/trafficcontrol/tc-health-client.log
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 6.1.0
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6456: Resolves issue #6439 by changing the TM endpoint used to get cache status using publish/CrStates
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6456:
URL: https://github.com/apache/trafficcontrol/pull/6456#discussion_r781399028
##########
File path: tc-health-client/tmagent/tmagent.go
##########
@@ -38,7 +38,7 @@ import (
"github.com/apache/trafficcontrol/lib/go-tc"
"github.com/apache/trafficcontrol/tc-health-client/config"
"github.com/apache/trafficcontrol/tc-health-client/util"
- "github.com/apache/trafficcontrol/traffic_monitor/datareq"
+ //"github.com/apache/trafficcontrol/traffic_monitor/datareq"
Review comment:
This comment should be removed:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford commented on a change in pull request #6456: Resolves issue #6439 by changing the TM endpoint used to get cache status using publish/CrStates
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #6456:
URL: https://github.com/apache/trafficcontrol/pull/6456#discussion_r781420454
##########
File path: tc-health-client/tmagent/tmagent.go
##########
@@ -38,7 +38,7 @@ import (
"github.com/apache/trafficcontrol/lib/go-tc"
"github.com/apache/trafficcontrol/tc-health-client/config"
"github.com/apache/trafficcontrol/tc-health-client/util"
- "github.com/apache/trafficcontrol/traffic_monitor/datareq"
+ //"github.com/apache/trafficcontrol/traffic_monitor/datareq"
Review comment:
@zrhoffman yeah, agreed. I overlooked that. I pushed the change and rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford commented on a change in pull request #6456: Resolves issue #6439 by changing the TM endpoint used to get cache status using publish/CrStates
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #6456:
URL: https://github.com/apache/trafficcontrol/pull/6456#discussion_r781420454
##########
File path: tc-health-client/tmagent/tmagent.go
##########
@@ -38,7 +38,7 @@ import (
"github.com/apache/trafficcontrol/lib/go-tc"
"github.com/apache/trafficcontrol/tc-health-client/config"
"github.com/apache/trafficcontrol/tc-health-client/util"
- "github.com/apache/trafficcontrol/traffic_monitor/datareq"
+ //"github.com/apache/trafficcontrol/traffic_monitor/datareq"
Review comment:
@zrhoffman yeah, agreed. I overlooked that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #6456: Resolves issue #6439 by changing the TM endpoint used to get cache status using publish/CrStates
Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #6456:
URL: https://github.com/apache/trafficcontrol/pull/6456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org