You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2022/08/06 09:54:16 UTC
[GitHub] [incubator-pagespeed-mod] oschaaf opened a new pull request, #2096: Get CI functional
oschaaf opened a new pull request, #2096:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2096
PR to iterate on getting CI functional again. It broke, but also needs some love to work with the new Envoy update:
- update the bazel and clang/llvm versions we use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf merged pull request #2096: Get CI functional
Posted by GitBox <gi...@apache.org>.
oschaaf merged PR #2096:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] jmarantz commented on pull request #2096: Get CI functional
Posted by GitBox <gi...@apache.org>.
jmarantz commented on PR #2096:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2096#issuecomment-1207249422
Or maybe we can pick a different url to test?
On Sat, Aug 6, 2022, 11:28 AM Otto van der Schaaf ***@***.***>
wrote:
> Allright this mostly works now, but
> SerfUrlAsyncFetcherTest.TestHttpsSucceedsForGoogleCom still fails,
> because the target url we test against started responding in a non-uniform
> way (CI gets a different response, apparently). Will fix tomorrow, by
> switching the target uri to a specific uri on modpagespeed.com.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-pagespeed-mod/pull/2096#issuecomment-1207234101>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAO2IPIHTACTQ7KD6Z3WFL3VX2ADDANCNFSM55YKLUJA>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf commented on pull request #2096: Get CI functional
Posted by GitBox <gi...@apache.org>.
oschaaf commented on PR #2096:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2096#issuecomment-1207234101
Allright this mostly works now, but `SerfUrlAsyncFetcherTest.TestHttpsSucceedsForGoogleCom` still fails, because the target url we test against started responding in a non-uniform way (CI gets a different response, apparently). Will fix tomorrow, by switching the target uri to a specific uri on modpagespeed.com.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf commented on pull request #2096: Get CI functional
Posted by GitBox <gi...@apache.org>.
oschaaf commented on PR #2096:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2096#issuecomment-1207445393
> Or maybe we can pick a different url to test?
Done in https://github.com/apache/incubator-pagespeed-mod/pull/2096/commits/fb15bcbf93fe865b8e16ecebf94c9439fb61c818
Let's see if CI passes with this change. If it does, I intend to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org