[GitHub] [calcite] rubenada commented on a diff in pull request #3258: [CALCITE-5771] Apply two different NULL semantics for CONCAT function(enabled in MySQL, Postgresql, BigQuery and MSSQL)

["rubenada (via GitHub)" <gi...@apache.org>]

rubenada commented on code in PR #3258:
URL: https://github.com/apache/calcite/pull/3258#discussion_r1232345665


##########
core/src/test/resources/sql/functions.iq:
##########
@@ -499,6 +510,120 @@ select CONVERT(DATE, '05/01/2000', 103);
 !ok
 !}
 
+# [CALCITE-5771] Apply two different NULL semantics for CONCAT function(enabled in MySQL, Postgresql, BigQuery and MSSQL)
+select concat(null);
++--------+
+| EXPR$0 |
++--------+
+|        |
++--------+
+(1 row)
+
+!ok
+
+select concat(null, '');
++--------+
+| EXPR$0 |
++--------+
+|        |
++--------+
+(1 row)
+
+!ok
+
+select concat('', '');
++--------+
+| EXPR$0 |
++--------+
+|        |

Review Comment:
   Stupid question: how can we distinguish if the expected result is the empty string (as in here) or null (as in the "concat in BigQuery" tests a few lines below)? Both cases look the same at first glance....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org