You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Jean-Baptiste Quenot <jb...@apache.org> on 2006/12/11 10:07:57 UTC
Last change required for reloading classes
Hi,
The code to reload classes is already in Wicket branch 1.x, but
there's a (hopefully) last fix to apply.
Could one of you please have a look at:
https://issues.apache.org/jira/secure/attachment/12346428/20061205-wicket-1.x-ReloadingClassLoader
* Use ArrayList instead of HashSet for the patterns to keep the order in which they were added
* Add methods includePattern() and excludePattern()
* Set default patterns in the static block
Thanks in advance,
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: Last change required for reloading classes
Posted by Bertrand Delacretaz <bd...@apache.org>.
On 12/21/06, Erik van Oosten <e....@chello.nl> wrote:
> The ssl certificate of Jira has expired :)
I have reported this at https://issues.apache.org/jira/browse/INFRA-1070
-Bertrand
Re: Last change required for reloading classes
Posted by Erik van Oosten <e....@chello.nl>.
The ssl certificate of Jira has expired :)
Erik.
Jean-Baptiste Quenot wrote:
> Could you please decide where this feature goes and close
> https://issues.apache.org/jira/browse/WICKET-126
>
>
--
Erik van Oosten
http://day-to-day-stuff.blogspot.com/
Re: Last change required for reloading classes
Posted by Igor Vaynberg <ig...@gmail.com>.
no i havent played with it and i dont think i will. hotswap is working great
for me and it doesnt introduce funky behavior like is possible with class
reloading.
eelco is the sponsor of this so we will have to wait for him to get back
from his holiday to decide where this should go and move it to the
appropriate place if you guys want it in core (next to wicket, extensions)
and he is willing to maintain it.
if neither he, nor any other committer, is willing to maintain it then you
can put it into wicket-stuff.
-igor
On 12/21/06, Jean-Baptiste Quenot <jb...@apache.org> wrote:
>
> * Igor Vaynberg:
>
> > if it doesnt work 100% of the time then imho it shouldnt be in
> > the core, i think it should go into a separate module or
> > extensions.
>
> Could you please decide where this feature goes and close
> https://issues.apache.org/jira/browse/WICKET-126
>
> So that it is included in time in the 1.3 release.
>
> Have you been able to test the feature? Feedback from more people
> is welcome!
>
> Thanks!
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>
Re: Last change required for reloading classes
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Igor Vaynberg:
> if it doesnt work 100% of the time then imho it shouldnt be in
> the core, i think it should go into a separate module or
> extensions.
Could you please decide where this feature goes and close
https://issues.apache.org/jira/browse/WICKET-126
So that it is included in time in the 1.3 release.
Have you been able to test the feature? Feedback from more people
is welcome!
Thanks!
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: Last change required for reloading classes
Posted by Igor Vaynberg <ig...@gmail.com>.
if it doesnt work 100% of the time then imho it shouldnt be in the core, i
think it should go into a separate module or extensions.
-igor
On 12/11/06, Eelco Hillenius <ee...@gmail.com> wrote:
>
> Sure, done.
>
> The issue is still open. I'm still not convinced we should ship the
> reloading filter tbh. As it only works with quite a few ifs and buts,
> I'd rather see the reloading filter (and class locator) to be part of
> wicket-extensions or maybe as a WIKI article or such. Though I'm fine
> with the patches that provide the basis for it to work (like setting
> the context loader etc)
>
> So far I think only Johan and I have looked at it, but before we
> decide on whether this should be part of Wicket core/ extensions or
> not, I think more people should look at it and give their opinions. My
> concern is not that this isn't useable - in fact I think many people
> will find it great - but I am afraid that if we officially support it,
> people *will* expect it to work for all occasions, and when it doesn't
> they would expect us to provide answers, fixes and so on. Personally,
> I'm not sure if I'm ready to do that.
>
> That said, I think the aim is great, and if there are improvements
> possible still and/ or other developers think it is a great addition
> we can certainly keep it in the pipe-line.
>
> Eelco
>
>
> On 12/11/06, Jean-Baptiste Quenot <jb...@apache.org> wrote:
> > Hi,
> >
> > The code to reload classes is already in Wicket branch 1.x, but
> > there's a (hopefully) last fix to apply.
> >
> > Could one of you please have a look at:
> >
> https://issues.apache.org/jira/secure/attachment/12346428/20061205-wicket-1.x-ReloadingClassLoader
> >
> > * Use ArrayList instead of HashSet for the patterns to keep the order in
> which they were added
> > * Add methods includePattern() and excludePattern()
> > * Set default patterns in the static block
> >
> > Thanks in advance,
> > --
> > Jean-Baptiste Quenot
> > aka John Banana Qwerty
> > http://caraldi.com/jbq/
> >
>
Re: Last change required for reloading classes
Posted by Eelco Hillenius <ee...@gmail.com>.
> BTW, is the reloading filter portable to Wicket-2.0? do you see any
> problem in using it with w-2.0?
I first wanted the implementation stable enough before we port the
changes to 2.0. There need to be a couple of tweaks before that filter
can be used, but not big things.
Eelco
Re: Last change required for reloading classes
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Filippo Diotalevi:
> BTW, is the reloading filter portable to Wicket-2.0? do you see
> any problem in using it with w-2.0?
Yes the patch is compatible with wicket trunk. Nothing prevents
to do the porting AFAICT.
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: Last change required for reloading classes
Posted by Filippo Diotalevi <fi...@gmail.com>.
On 12/11/06, Eelco Hillenius <ee...@gmail.com> wrote:
> Sure, done.
> The issue is still open. I'm still not convinced we should ship the
> reloading filter tbh. As it only works with quite a few ifs and buts,
> I'd rather see the reloading filter (and class locator) to be part of
> wicket-extensions or maybe as a WIKI article or such. Though I'm fine
> with the patches that provide the basis for it to work (like setting
> the context loader etc)
Hi,
I've played a bit with the reloading filter and find it great;
obviously supporting it in all possible environments is an hard work,
but I'd like it to be part of the project (in wicket-extensions or,
why not, a new wicket-reloading-filter package)
BTW, is the reloading filter portable to Wicket-2.0? do you see any
problem in using it with w-2.0?
--
Filippo
Re: Last change required for reloading classes
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* Eelco Hillenius:
> As it only works with quite a few ifs and buts,
It works great with the wicket-examples and all Wicket
applications, but it's true that things get more complicated when
using a component manager like Spring, because then you need to
have proper separation between the presentation layer and the
business model. In this case we could provide a FAQ entry
like: « Why do I get a ClassCastException when turning on
ReloadingWicketFilter » and explain how to solve the issue by
fiddling with the include/exclude patterns.
> So far I think only Johan and I have looked at it, but before we
> decide on whether this should be part of Wicket core/ extensions
> or not, I think more people should look at it and give their
> opinions.
You're right, I invite every Wicket developer and all users that
can afford to checkout the code to test this feature, to have more
feedback and ensure it works smoothly.
> My concern is not that this isn't useable - in fact I think many
> people will find it great - but I am afraid that if we
> officially support it, people *will* expect it to work for all
> occasions, and when it doesn't they would expect us to provide
> answers, fixes and so on. Personally, I'm not sure if I'm ready
> to do that.
I'd be glad to maintain the code and provide support for it, FWIW.
Cheers,
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: Last change required for reloading classes
Posted by Eelco Hillenius <ee...@gmail.com>.
Sure, done.
The issue is still open. I'm still not convinced we should ship the
reloading filter tbh. As it only works with quite a few ifs and buts,
I'd rather see the reloading filter (and class locator) to be part of
wicket-extensions or maybe as a WIKI article or such. Though I'm fine
with the patches that provide the basis for it to work (like setting
the context loader etc)
So far I think only Johan and I have looked at it, but before we
decide on whether this should be part of Wicket core/ extensions or
not, I think more people should look at it and give their opinions. My
concern is not that this isn't useable - in fact I think many people
will find it great - but I am afraid that if we officially support it,
people *will* expect it to work for all occasions, and when it doesn't
they would expect us to provide answers, fixes and so on. Personally,
I'm not sure if I'm ready to do that.
That said, I think the aim is great, and if there are improvements
possible still and/ or other developers think it is a great addition
we can certainly keep it in the pipe-line.
Eelco
On 12/11/06, Jean-Baptiste Quenot <jb...@apache.org> wrote:
> Hi,
>
> The code to reload classes is already in Wicket branch 1.x, but
> there's a (hopefully) last fix to apply.
>
> Could one of you please have a look at:
> https://issues.apache.org/jira/secure/attachment/12346428/20061205-wicket-1.x-ReloadingClassLoader
>
> * Use ArrayList instead of HashSet for the patterns to keep the order in which they were added
> * Add methods includePattern() and excludePattern()
> * Set default patterns in the static block
>
> Thanks in advance,
> --
> Jean-Baptiste Quenot
> aka John Banana Qwerty
> http://caraldi.com/jbq/
>