[GitHub] spark pull request #16810: [SPARK-19464][CORE][YARN][test-hadoop2.6] Remove ...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16810#discussion_r99503085
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala ---
    @@ -63,17 +63,16 @@ private[hive] object IsolatedClientLoader extends Logging {
             } catch {
               case e: RuntimeException if e.getMessage.contains("hadoop") =>
                 // If the error message contains hadoop, it is probably because the hadoop
    -            // version cannot be resolved (e.g. it is a vendor specific version like
    -            // 2.0.0-cdh4.1.1). If it is the case, we will try just
    -            // "org.apache.hadoop:hadoop-client:2.4.0". "org.apache.hadoop:hadoop-client:2.4.0"
    +            // version cannot be resolved. If it is the case, we will try just
    +            // "org.apache.hadoop:hadoop-client:2.6.0". "org.apache.hadoop:hadoop-client:2.6.0"
                 // is used just because we used to hard code it as the hadoop artifact to download.
    -            logWarning(s"Failed to resolve Hadoop artifacts for the version ${hadoopVersion}. " +
    -              s"We will change the hadoop version from ${hadoopVersion} to 2.4.0 and try again. " +
    +            logWarning(s"Failed to resolve Hadoop artifacts for the version $hadoopVersion. " +
    +              s"We will change the hadoop version from $hadoopVersion to 2.6.0 and try again. " +
                   "Hadoop classes will not be shared between Spark and Hive metastore client. " +
                   "It is recommended to set jars used by Hive metastore client through " +
                   "spark.sql.hive.metastore.jars in the production environment.")
                 sharesHadoopClasses = false
    -            (downloadVersion(resolvedVersion, "2.4.0", ivyPath), "2.4.0")
    +            (downloadVersion(resolvedVersion, "2.6.0", ivyPath), "2.6.0")
    --- End diff --
    
    should this be 2.6.5, matching `<hadoop.version>2.6.5</hadoop.version>`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org