You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "grundprinzip (via GitHub)" <gi...@apache.org> on 2024/02/29 16:02:08 UTC
[PR] [SPARK-47227][FOLLOW][DOCS] Improve Spark Connect Documentation [spark]
grundprinzip opened a new pull request, #45339:
URL: https://github.com/apache/spark/pull/45339
### What changes were proposed in this pull request?
Language improvements from https://github.com/apache/spark/pull/45335.
### Why are the changes needed?
Readability.
### Does this PR introduce _any_ user-facing change?
Documentation only.
### How was this patch tested?
N/A
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47227][FOLLOW][DOCS] Improve Spark Connect Documentation [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on code in PR #45339:
URL: https://github.com/apache/spark/pull/45339#discussion_r1509439684
##########
docs/spark-connect-overview.md:
##########
@@ -67,8 +67,8 @@ that developers need to be aware of when using Spark Connect:
the execution environment. In particular, in PySpark, the client does not use Py4J
and thus the accessing the private fields holding the JVM implementation of `DataFrame`,
`Column`, `SparkSession`, etc. is not possible (e.g. `df._jdf`).
-2. By design, the Spark Connect protocol is designed around the concepts of Sparks logical
- plans as the abstraction to be able to declarative describe the operations to be executed
+2. By design, the Spark Connect protocol uses Sparks logical
Review Comment:
nit: Spark`'`s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47227][FOLLOW][DOCS] Improve Spark Connect Documentation [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #45339:
URL: https://github.com/apache/spark/pull/45339#issuecomment-1973783953
LGTM, thank you! Looks much clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47227][FOLLOW][DOCS] Improve Spark Connect Documentation [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #45339: [SPARK-47227][FOLLOW][DOCS] Improve Spark Connect Documentation
URL: https://github.com/apache/spark/pull/45339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47227][FOLLOW][DOCS] Improve Spark Connect Documentation [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on code in PR #45339:
URL: https://github.com/apache/spark/pull/45339#discussion_r1507868747
##########
docs/spark-connect-overview.md:
##########
@@ -56,7 +56,7 @@ client through gRPC as Apache Arrow-encoded row batches.
<img src="img/spark-connect-communication.png" title="Spark Connect communication" alt="Spark Connect communication" />
</p>
-## What is changing with Spark Connect
+## How Spark Connect client applications differ from classic Spark applications
Review Comment:
This is much clearer. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47227][FOLLOW][DOCS] Improve Spark Connect Documentation [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45339:
URL: https://github.com/apache/spark/pull/45339#issuecomment-1973806289
+1, LGTM. Merging to master.
Thank you, @grundprinzip and @xinrong-meng @nchammas for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47227][FOLLOW][DOCS] Improve Spark Connect Documentation [spark]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #45339:
URL: https://github.com/apache/spark/pull/45339#discussion_r1507823877
##########
docs/spark-connect-overview.md:
##########
@@ -56,7 +56,7 @@ client through gRPC as Apache Arrow-encoded row batches.
<img src="img/spark-connect-communication.png" title="Spark Connect communication" alt="Spark Connect communication" />
</p>
-## What is changing with Spark Connect
+## How Spark Connect client applications differ from classic Spark applications
Review Comment:
@nchammas what about this proposal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org