You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "He Yongqiang (JIRA)" <ji...@apache.org> on 2011/05/10 00:49:03 UTC
[jira] [Created] (HIVE-2154) add exception handling to hive's
record reader
add exception handling to hive's record reader
-----------------------------------------------
Key: HIVE-2154
URL: https://issues.apache.org/jira/browse/HIVE-2154
Project: Hive
Issue Type: Improvement
Reporter: He Yongqiang
Assignee: He Yongqiang
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2154) add exception handling to hive's
record reader
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-2154:
-------------------------------
Attachment: HIVE-2154.2.patch
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch, HIVE-2154.2.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2154) add exception handling to hive's
record reader
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041917#comment-13041917 ]
jiraposter@reviews.apache.org commented on HIVE-2154:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/812/
-----------------------------------------------------------
(Updated 2011-06-01 00:38:42.863958)
Review request for hive.
Changes
-------
address Ning's comments to move some code to hadoopshims
Summary
-------
add exception handling to hive's record reader
This addresses bug HIVE-2154.
https://issues.apache.org/jira/browse/HIVE-2154
Diffs (updated)
-----
trunk/conf/hive-default.xml 1129953
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java 1129953
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 1129953
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java 1129953
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java 1129953
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java 1129953
trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 1129953
trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1129953
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandler.java PRE-CREATION
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java PRE-CREATION
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java PRE-CREATION
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNextHandleResult.java PRE-CREATION
Diff: https://reviews.apache.org/r/812/diff
Testing
-------
Thanks,
Yongqiang
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch, HIVE-2154.2.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2154) add exception handling to hive's
record reader
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-2154:
-------------------------------
Attachment: HIVE-2154.3.patch
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch, HIVE-2154.2.patch, HIVE-2154.3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2154) add exception handling to hive's
record reader
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042031#comment-13042031 ]
jiraposter@reviews.apache.org commented on HIVE-2154:
-----------------------------------------------------
bq. On 2011-06-01 06:48:14, Ning Zhang wrote:
bq. > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java, line 57
bq. > <https://reviews.apache.org/r/812/diff/2/?file=20084#file20084line57>
bq. >
bq. > Do you need to throw exception when all handler return false?
ioExpectionHandlerChain will throw exception if all handler returns false.
- Yongqiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/812/#review741
-----------------------------------------------------------
On 2011-06-01 00:38:42, Yongqiang He wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/812/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-01 00:38:42)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. add exception handling to hive's record reader
bq.
bq.
bq. This addresses bug HIVE-2154.
bq. https://issues.apache.org/jira/browse/HIVE-2154
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/conf/hive-default.xml 1129953
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java 1129953
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 1129953
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java 1129953
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java 1129953
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java 1129953
bq. trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 1129953
bq. trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1129953
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandler.java PRE-CREATION
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java PRE-CREATION
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java PRE-CREATION
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNextHandleResult.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/812/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Yongqiang
bq.
bq.
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch, HIVE-2154.2.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2154) add exception handling to hive's
record reader
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042007#comment-13042007 ]
jiraposter@reviews.apache.org commented on HIVE-2154:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/812/#review741
-----------------------------------------------------------
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java
<https://reviews.apache.org/r/812/#comment1516>
This function is not intuitive. Maybe you need more comments about the why it is designed this way.
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java
<https://reviews.apache.org/r/812/#comment1514>
Do you need to throw exception when all handler return false?
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java
<https://reviews.apache.org/r/812/#comment1515>
same as above
- Ning
On 2011-06-01 00:38:42, Yongqiang He wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/812/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-01 00:38:42)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. add exception handling to hive's record reader
bq.
bq.
bq. This addresses bug HIVE-2154.
bq. https://issues.apache.org/jira/browse/HIVE-2154
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/conf/hive-default.xml 1129953
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java 1129953
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 1129953
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java 1129953
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java 1129953
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java 1129953
bq. trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 1129953
bq. trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1129953
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandler.java PRE-CREATION
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java PRE-CREATION
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java PRE-CREATION
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNextHandleResult.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/812/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Yongqiang
bq.
bq.
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch, HIVE-2154.2.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2154) add exception handling to hive's
record reader
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-2154:
-------------------------------
Status: Patch Available (was: Open)
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2154) add exception handling to hive's
record reader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042717#comment-13042717 ]
Hudson commented on HIVE-2154:
------------------------------
Integrated in Hive-trunk-h0.21 #756 (See [https://builds.apache.org/hudson/job/Hive-trunk-h0.21/756/])
HIVE-2154. add exception handling to hive's record reader (Yongqiang He via Ning Zhang)
nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130427
Files :
* /hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
* /hive/trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNextHandleResult.java
* /hive/trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java
* /hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java
* /hive/trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java
* /hive/trunk/shims/src/common/java/org/apache/hadoop/hive/io
* /hive/trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandler.java
* /hive/trunk/conf/hive-default.xml
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Fix For: 0.8.0
>
> Attachments: HIVE-2154.1.patch, HIVE-2154.2.patch, HIVE-2154.3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2154) add exception handling to hive's
record reader
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041804#comment-13041804 ]
He Yongqiang commented on HIVE-2154:
------------------------------------
https://reviews.apache.org/r/812/
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2154) add exception handling to hive's
record reader
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041806#comment-13041806 ]
jiraposter@reviews.apache.org commented on HIVE-2154:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/812/
-----------------------------------------------------------
(Updated 2011-05-31 20:31:23.581581)
Review request for hive.
Changes
-------
add exception handling to hive's record reader
Summary
-------
add exception handling to hive's record reader
This addresses bug HIVE-2154.
https://issues.apache.org/jira/browse/HIVE-2154
Diffs
-----
trunk/conf/hive-default.xml 1127229
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java 1101261
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 1101261
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java 1101261
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java 1101261
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java 1101261
trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 1101261
trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1101261
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandler.java PRE-CREATION
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java PRE-CREATION
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNextHandleResult.java PRE-CREATION
Diff: https://reviews.apache.org/r/812/diff
Testing
-------
Thanks,
Yongqiang
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2154) add exception handling to hive's
record reader
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042602#comment-13042602 ]
Ning Zhang commented on HIVE-2154:
----------------------------------
+1
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch, HIVE-2154.2.patch, HIVE-2154.3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2154) add exception handling to hive's
record reader
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Zhang updated HIVE-2154:
-----------------------------
Resolution: Fixed
Fix Version/s: 0.8.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks Yongqiang!
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Fix For: 0.8.0
>
> Attachments: HIVE-2154.1.patch, HIVE-2154.2.patch, HIVE-2154.3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2154) add exception handling to hive's
record reader
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-2154:
-------------------------------
Attachment: HIVE-2154.1.patch
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2154) add exception handling to hive's
record reader
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041797#comment-13041797 ]
Ning Zhang commented on HIVE-2154:
----------------------------------
Yongqiang, can you post it to review board? It's much easier that way.
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2154) add exception handling to hive's
record reader
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041835#comment-13041835 ]
jiraposter@reviews.apache.org commented on HIVE-2154:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/812/#review740
-----------------------------------------------------------
trunk/conf/hive-default.xml
<https://reviews.apache.org/r/812/#comment1493>
comment should be more specific: class names of the exception handlers.
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java
<https://reviews.apache.org/r/812/#comment1494>
rename the variable to indicate it is a chain rather than just 1 handler.
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java
<https://reviews.apache.org/r/812/#comment1497>
this function throws IOException but the original code throws RuntimeException. Should check if this is OK.
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java
<https://reviews.apache.org/r/812/#comment1496>
same as below
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java
<https://reviews.apache.org/r/812/#comment1495>
check if the function return false and throw exception
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
<https://reviews.apache.org/r/812/#comment1498>
indentation
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
<https://reviews.apache.org/r/812/#comment1499>
comment on what the innerReader is when there is an exception in the first call of getRecordReader().
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
<https://reviews.apache.org/r/812/#comment1500>
also need to throw exception when all handlers return false. Should try to refactor the code
- Ning
On 2011-05-31 20:31:23, Yongqiang He wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/812/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-05-31 20:31:23)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. add exception handling to hive's record reader
bq.
bq.
bq. This addresses bug HIVE-2154.
bq. https://issues.apache.org/jira/browse/HIVE-2154
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/conf/hive-default.xml 1127229
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java 1101261
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 1101261
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java 1101261
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java 1101261
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java 1101261
bq. trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 1101261
bq. trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1101261
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandler.java PRE-CREATION
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java PRE-CREATION
bq. trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNextHandleResult.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/812/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Yongqiang
bq.
bq.
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira