You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "seropian (via GitHub)" <gi...@apache.org> on 2025/10/01 07:38:17 UTC

Re: [PR] OAK-11267: Upgrade Azure SDK V8 to V12 for oak-blob-azure [jackrabbit-oak]

seropian commented on code in PR #2409:
URL: https://github.com/apache/jackrabbit-oak/pull/2409#discussion_r2393715428


##########
oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureDataStore.java:
##########
@@ -41,11 +43,18 @@ public class AzureDataStore extends AbstractSharedCachingDataStore implements Co
 
     protected Properties properties;
 
-    private AzureBlobStoreBackend azureBlobStoreBackend;
+    private AbstractAzureBlobStoreBackend azureBlobStoreBackend;
+
+    private final boolean useAzureSdkV12 = SystemPropertySupplier.create("blob.azure.v12.enabled", false).get();
 
     @Override
     protected AbstractSharedBackend createBackend() {
-        azureBlobStoreBackend = new AzureBlobStoreBackend();
+        if (useAzureSdkV12) {
+            azureBlobStoreBackend = new AzureBlobStoreBackend();

Review Comment:
   added



##########
oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureDataStore.java:
##########
@@ -41,11 +43,18 @@ public class AzureDataStore extends AbstractSharedCachingDataStore implements Co
 
     protected Properties properties;
 
-    private AzureBlobStoreBackend azureBlobStoreBackend;
+    private AbstractAzureBlobStoreBackend azureBlobStoreBackend;
+
+    private final boolean useAzureSdkV12 = SystemPropertySupplier.create("blob.azure.v12.enabled", false).get();
 
     @Override
     protected AbstractSharedBackend createBackend() {
-        azureBlobStoreBackend = new AzureBlobStoreBackend();
+        if (useAzureSdkV12) {
+            azureBlobStoreBackend = new AzureBlobStoreBackend();
+        } else {
+            azureBlobStoreBackend = new AzureBlobStoreBackendV8();

Review Comment:
   added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org