You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/16 01:51:23 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2146: [KYUUBI #2024] Hive Backend Engine - ProcBuilder for HiveEngine

pan3793 commented on a change in pull request #2146:
URL: https://github.com/apache/incubator-kyuubi/pull/2146#discussion_r827558030



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/engine/EngineType.scala
##########
@@ -23,5 +23,5 @@ package org.apache.kyuubi.engine
 object EngineType extends Enumeration {
   type EngineType = Value
 
-  val SPARK_SQL, FLINK_SQL, TRINO = Value
+  val SPARK_SQL, FLINK_SQL, TRINO, HIVE_SQL = Value

Review comment:
       I think we should use `HIVE` here, for Flink and Spark, they provide user interfaces not only SQL, for Trino and Hive, only SQL, `HIVE_SQL` is quite redundant.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org