You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/23 19:48:40 UTC

[GitHub] [activemq] jgallimore opened a new pull request #638: Forward commit commands for local transactions as well as XA transact…

jgallimore opened a new pull request #638:
URL: https://github.com/apache/activemq/pull/638


   …ions during ACK compaction
   
   This is a backport of #636 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] cshannon commented on pull request #638: Forward commit commands for local transactions as well as XA transact…

Posted by GitBox <gi...@apache.org>.
cshannon commented on pull request #638:
URL: https://github.com/apache/activemq/pull/638#issuecomment-805276443


   @gtully - Any thoughts on this Gary? This change makes sense to me at first glance but it looks like you initially added the check for just XA transactions [here](https://github.com/apache/activemq/commit/f7ff4c25e13133132c3103141a5179c93e43b536). I was curious if there was a reason you didn't initially include local Tx as well?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] jgallimore commented on pull request #638: Forward commit commands for local transactions as well as XA transact…

Posted by GitBox <gi...@apache.org>.
jgallimore commented on pull request #638:
URL: https://github.com/apache/activemq/pull/638#issuecomment-805648112


   Closing this as it'll be cherry-picked to the other branches after being merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] jgallimore closed pull request #638: Forward commit commands for local transactions as well as XA transact…

Posted by GitBox <gi...@apache.org>.
jgallimore closed pull request #638:
URL: https://github.com/apache/activemq/pull/638


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org