You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/03 15:23:52 UTC

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r625164696



##########
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##########
@@ -412,12 +412,6 @@ abstract class AbstractFetcherThread(name: String,
                        "expected to persist.")
                   partitionsWithError += topicPartition
 
-                case Errors.UNKNOWN_TOPIC_ID =>

Review comment:
       With the top level error change, we are no longer marking the partitions as `partitionsWithError`. I'm wondering if this is something we still want to do somehow to allow the broker's metadata time to update.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org