[jira] [Commented] (METRON-1107) add support for handling epoch dates in seconds or milliseconds

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125072#comment-16125072 ] 

ASF GitHub Bot commented on METRON-1107:
----------------------------------------

Github user JonZeolla commented on a diff in the pull request:

    https://github.com/apache/metron/pull/692#discussion_r132855988
  
    --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java ---
    @@ -0,0 +1,44 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.metron.stellar.common.utils;
    +
    +/**
    + * Utility functions for working with numbers that represent different
    + * formats of EPOCH time.
    + */
    +public class EpochUtils {
    +
    +  /**
    +   * Ensures returns the passed value as milliseconds from EPOCH if the value is in seconds.
    +   * This is done by looking at the number of digits.
    +   * If there are 10, then the value is concidered to be in seconds and will by
    +   * muliplited by 1000.
    +   * If there not 10, then the original value will be returned.
    +   *
    +   *
    +   * </p>
    +   * @param canidate The Long value to concider
    +   * @return A Long value
    +   */
    +  public static Long ensureEpochMillis(Long canidate) {
    --- End diff --
    
    `s/canidate/candidate/g` for this whole file


> add support for handling epoch dates in seconds or milliseconds
> ---------------------------------------------------------------
>
>                 Key: METRON-1107
>                 URL: https://issues.apache.org/jira/browse/METRON-1107
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Jon Zeolla
>            Assignee: Otto Fowler
>
> While testing METRON-1091 I found an issue where the DAY_OF_YEAR was improperly returning the same as DAY_OF_MONTH, but the DAY_OF_MONTH was also incorrect.
> [Stellar]>>> DAY_OF_YEAR(1483239091)
> 17
> [Stellar]>>> DAY_OF_MONTH(1483239091)
> 17
> [Stellar]>>> DAY_OF_MONTH(1502592893)
> 18
> [Stellar]>>> DAY_OF_YEAR(1502592893)
> 18



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)