[incubator-uniffle] branch master updated: [MINOR] Fix flaky test (#238)

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new d680a0c5 [MINOR] Fix flaky test (#238)
d680a0c5 is described below

commit d680a0c5cb2e9baf09d31c34c5684d171cd4f285
Author: roryqi <je...@gmail.com>
AuthorDate: Fri Sep 23 10:14:38 2022 +0800

    [MINOR] Fix flaky test (#238)
    
    ### What changes were proposed in this pull request?
    `org.apache.uniffle.test.GetShuffleReportForMultiPartTest` is flaky
     throws Exception:
    ava.lang.ClassCastException: org.apache.spark.shuffle.RssShuffleManager cannot be cast to org.apache.uniffle.test.GetShuffleReportForMultiPartTest$RssShuffleManagerWrapper
            at org.apache.uniffle.test.GetShuffleReportForMultiPartTest.runTest(GetShuffleReportForMultiPartTest.java:180)
            at org.apache.uniffle.test.SparkIntegrationTestBase.runSparkApp(SparkIntegrationTestBase.java:74)
            at org.apache.uniffle.test.SparkIntegrationTestBase.run(SparkIntegrationTestBase.java:52)
            at org.apache.uniffle.test.GetShuffleReportForMultiPartTest.resultCompareTest(GetShuffleReportForMultiPartTest.java:141)
    
    ### Why are the changes needed?
    Fix flaky test
    
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    GA passed
    
    Co-authored-by: roryqi <ro...@tencent.com>
---
 .../java/org/apache/uniffle/test/GetShuffleReportForMultiPartTest.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/integration-test/spark3/src/test/java/org/apache/uniffle/test/GetShuffleReportForMultiPartTest.java b/integration-test/spark3/src/test/java/org/apache/uniffle/test/GetShuffleReportForMultiPartTest.java
index f719c96d..899970ce 100644
--- a/integration-test/spark3/src/test/java/org/apache/uniffle/test/GetShuffleReportForMultiPartTest.java
+++ b/integration-test/spark3/src/test/java/org/apache/uniffle/test/GetShuffleReportForMultiPartTest.java
@@ -175,7 +175,8 @@ public class GetShuffleReportForMultiPartTest extends SparkIntegrationTestBase {
       i++;
     }
     SparkConf conf = spark.sparkContext().conf();
-    if (!conf.get("spark.shuffle.manager", "").isEmpty()) {
+    if (conf.get("spark.shuffle.manager", "")
+        .equals("org.apache.uniffle.test.GetShuffleReportForMultiPartTest$RssShuffleManagerWrapper")) {
       RssShuffleManagerWrapper mockRssShuffleManager =
           (RssShuffleManagerWrapper) spark.sparkContext().env().shuffleManager();
       int expectRequestNum = mockRssShuffleManager.getShuffleIdToPartitionNum().values().stream()