You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2016/03/01 02:15:18 UTC
[jira] [Updated] (SPARK-13583) Support `UnusedImports` Java
checkstyle rule
[ https://issues.apache.org/jira/browse/SPARK-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dongjoon Hyun updated SPARK-13583:
----------------------------------
Description:
After SPARK-6990, `dev/lint-java` keeps Java code healthy and helps PR review by saving much time.
This issue aims to enforce `UnusedImports` rule by adding a `UnusedImports` rule to `checkstyle.xml` and fixing all existing unused imports.
{code:title=checkstyle.xml|borderStyle=solid}
+ <module name="UnusedImports"/>
{code}
Unfortunately, `dev/lint-java` is not tested by Jenkins. ( https://github.com/apache/spark/blob/master/dev/run-tests.py#L546 )
This will also help Spark contributors to check by themselves before submitting their PRs.
was:
After SPARK-6990, `dev/lint-java` keeps Java code healthy and helps PR review by saving much time.
This issue aims to enforce `UnusedImports` rule by adding a `UnusedImports` rule to `checkstyle.xml` and fixing all existing unused imports.
{code:title=checkstyle.xml|borderStyle=solid}
+ <module name="UnusedImports"/>
{code}
This will also prevent the upcoming PR from having unused imports.
Summary: Support `UnusedImports` Java checkstyle rule (was: Enforce `UnusedImports` Java checkstyle rule)
> Support `UnusedImports` Java checkstyle rule
> --------------------------------------------
>
> Key: SPARK-13583
> URL: https://issues.apache.org/jira/browse/SPARK-13583
> Project: Spark
> Issue Type: Task
> Reporter: Dongjoon Hyun
> Priority: Trivial
>
> After SPARK-6990, `dev/lint-java` keeps Java code healthy and helps PR review by saving much time.
> This issue aims to enforce `UnusedImports` rule by adding a `UnusedImports` rule to `checkstyle.xml` and fixing all existing unused imports.
> {code:title=checkstyle.xml|borderStyle=solid}
> + <module name="UnusedImports"/>
> {code}
> Unfortunately, `dev/lint-java` is not tested by Jenkins. ( https://github.com/apache/spark/blob/master/dev/run-tests.py#L546 )
> This will also help Spark contributors to check by themselves before submitting their PRs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org