You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/03/02 17:39:56 UTC

Re: Review Request 57048: ATLAS-1622: Full text mapper V2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57048/
-----------------------------------------------------------

(Updated March 2, 2017, 5:39 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.


Changes
-------

Added JIRA details


Summary (updated)
-----------------

ATLAS-1622: Full text mapper V2


Bugs: ATLAS-1622
    https://issues.apache.org/jira/browse/ATLAS-1622


Repository: atlas


Description
-------

Move from older APIs towards new V2 model.


Diffs
-----

  repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java 1f2a7545 
  repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 89f48edf 
  repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 44614472 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java dfa44079 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java feada348 
  server-api/src/main/java/org/apache/atlas/RequestContext.java bb11d671 


Diff: https://reviews.apache.org/r/57048/diff/1/


Testing
-------

mvn clean package was successfully executed.


Thanks,

Apoorv Naik

Re: Review Request 57048: ATLAS-1622: Full text mapper V2

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57048/#review167737
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
Lines 89 (patched)
<https://reviews.apache.org/r/57048/#comment239664>

    handle null for 'entityWithExtInfo' here



repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
Lines 136 (patched)
<https://reviews.apache.org/r/57048/#comment239689>

    This could cause infinite recursion for cases where entities refer to each other - like: hive_table.columns and hive_column.table


- Madhan Neethiraj


On March 2, 2017, 5:39 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57048/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 5:39 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1622
>     https://issues.apache.org/jira/browse/ATLAS-1622
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Move from older APIs towards new V2 model.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java 1f2a7545 
>   repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 89f48edf 
>   repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 44614472 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java dfa44079 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java feada348 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java bb11d671 
> 
> 
> Diff: https://reviews.apache.org/r/57048/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean package was successfully executed.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 57048: ATLAS-1622: Full text mapper V2

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57048/#review167781
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On March 3, 2017, 12:21 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57048/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 12:21 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1622
>     https://issues.apache.org/jira/browse/ATLAS-1622
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Move from older APIs towards new V2 model.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java 1f2a7545 
>   repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 89f48edf 
>   repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 44614472 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java dfa44079 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java e112b640 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java bb11d671 
> 
> 
> Diff: https://reviews.apache.org/r/57048/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean package was successfully executed.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 57048: ATLAS-1622: Full text mapper V2

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57048/
-----------------------------------------------------------

(Updated March 3, 2017, 12:21 a.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.


Changes
-------

Addressed review comments for null checks and recursion check


Bugs: ATLAS-1622
    https://issues.apache.org/jira/browse/ATLAS-1622


Repository: atlas


Description
-------

Move from older APIs towards new V2 model.


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java 1f2a7545 
  repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 89f48edf 
  repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 44614472 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java dfa44079 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java e112b640 
  server-api/src/main/java/org/apache/atlas/RequestContext.java bb11d671 


Diff: https://reviews.apache.org/r/57048/diff/2/

Changes: https://reviews.apache.org/r/57048/diff/1-2/


Testing
-------

mvn clean package was successfully executed.


Thanks,

Apoorv Naik