You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2017/08/14 15:44:26 UTC

[GitHub] activemq-artemis pull request #1462: Manage client objects

GitHub user mtaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1462

    Manage client objects

    This patch adds views for managing client objects from the console.  Filtering and paging is enabled.  There are still some improvements that can be made such as more optimising filters, more filtering operations and some code restructure.  However, this is already 3 huge commits, I'd like to get this in and improve iteratively on master.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mtaylor/activemq-artemis ManageClientObjects

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1462
    
----
commit b37c1a534152a085e4142e4f80b120ed06c8674a
Author: Martyn Taylor <mt...@redhat.com>
Date:   2017-08-14T15:39:55Z

    ARTEMIS-1349 Add management views for client objects

commit 4e129e7e41d6fe53e8e3f51e6e024600f1cf0d05
Author: Martyn Taylor <mt...@redhat.com>
Date:   2017-08-14T15:40:24Z

    ARTEMIS-1350 Expose Client Objects in Console

commit 870e731b9c70130ded49ccd302cf32b97681dfd6
Author: Martyn Taylor <mt...@redhat.com>
Date:   2017-08-14T15:41:01Z

    NOJIRA Console branding/style improvements

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    Pulled out the retheme.  Will open a separate PR.  @michaelandrepearce  pointed out an issue with the producer address filter.  Will fix that up now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    Everything looks great here.. only thing is the temporary destinations (think of request/response).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    @clebertsuconic I will fix it before we release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    Think you should leave out the re-theme for now (this should be separate PR), lots of CSS issues on position and alignment, and font sizing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    @mtaylor if I use the session to send on multiple addresses, aren't you creating more producers?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    It wasn't a bug till you Merged it... now temporary queues are not so temporary ;)
    
    You need to listen for temp queue removes and remove the producer upon temporary queue removal.  
    
    
    No need to open a JIRA for that.  Just use this one.  
    
    
    
    But we can't release with that.  It is a reason for -1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    @andytaylor


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    Fixed the filter on producer address.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1462: Manage client objects

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1462


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    @mtaylor  I see.. it's fine then.. sorry for the red herring.. I thought it was creating a leakage.
    
    in case you implement new producers for new packets coming... then you would need to cleanup temporary queues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    @andytwylor this was Merged with a bug I mentioned earlier.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    No.  This is a 1st step simple implementation.  For the CORE protocol a producer is simply represented as the defaultAddress on the session and nothing more.  In subsequent versions I intend to add a producer object to the CORE protocol.  But that requires significant change that goes beyond this PR.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    +1, as discussed further bits can be in follow up PR's


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    @andytaylor I think what @clebertsuconic is referring to is this comment: 
    
    "only thing is the temporary destinations (think of request/response)."
    
    I had with @clebertsuconic who mentioned there may be a leak with addProducer() when using temporary destinations.  i.e. the producer may not be removed.  @andytaylor This something you could look at?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    @clebertsuconic I had a quick scout over the code.  Can you elaborate a little.  I think you are referrign to the add/removeProducers since this is the only new object that was added.  Right now this is only used in two places.  In CORE on session create (the producer is added to the newly created session) and in AMQP on linkAttach/Detach.  Is there a place where add occurs but remove does not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1462: Manage client objects

Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1462
  
    @clebertsuconic I dont see mention of a bug?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---