You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/07 23:00:10 UTC
[GitHub] [pulsar] adithyaakrishna opened a new pull request #10511: [Bug] - Fixed Broken Links at Licensing & K8S Cluster Setup on AWS
adithyaakrishna opened a new pull request #10511:
URL: https://github.com/apache/pulsar/pull/10511
Signed-off-by: Adithya Krishna <aa...@gmail.com>
Fixes #9730
### Motivation
To ensure, the links are addressed to the write webpages.
### Modifications
*Describe the modifications you've done.*
Fixed the links, https://pulsar.apache.org/en/coding-guide/ and another one linked to setting up Kubernetes cluster on AWS
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage: **Yes**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] adithyaakrishna commented on a change in pull request #10511: [Bug] - Fixed Broken Links at Licensing & K8S Cluster Setup on AWS
Posted by GitBox <gi...@apache.org>.
adithyaakrishna commented on a change in pull request #10511:
URL: https://github.com/apache/pulsar/pull/10511#discussion_r628707472
##########
File path: site2/website/coding-guide.md
##########
@@ -20,7 +20,7 @@ Apache Pulsar uses the following libraries a lot:
Use these libraries whenever possible rather than introducing more dependencies.
-Dependencies are bundled with our binary distributions, so we need to attach the relevant licenses. See [Third party dependencies and licensing](/community/licensing) for a guide on how to do it correctly.
+Dependencies are bundled with our binary distributions, so we need to attach the relevant licenses. See [Third party dependencies and licensing](https://pulsar.apache.org/docs/en/client-libraries/) for a guide on how to do it correctly.
Review comment:
Also, I'm not sure why the Ci Checks aren't running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #10511: [Bug] - Fixed Broken Links at Licensing & K8S Cluster Setup on AWS
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #10511:
URL: https://github.com/apache/pulsar/pull/10511#discussion_r628708723
##########
File path: site2/website/coding-guide.md
##########
@@ -20,7 +20,7 @@ Apache Pulsar uses the following libraries a lot:
Use these libraries whenever possible rather than introducing more dependencies.
-Dependencies are bundled with our binary distributions, so we need to attach the relevant licenses. See [Third party dependencies and licensing](/community/licensing) for a guide on how to do it correctly.
+Dependencies are bundled with our binary distributions, so we need to attach the relevant licenses. See [Third party dependencies and licensing](https://pulsar.apache.org/docs/en/client-libraries/) for a guide on how to do it correctly.
Review comment:
Don't worry about the CI check. After approval, we will run the tests.
I'll check the link and let you know when I have the answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #10511: [Bug] - Fixed Broken Links at Licensing & K8S Cluster Setup on AWS
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10511:
URL: https://github.com/apache/pulsar/pull/10511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] adithyaakrishna commented on a change in pull request #10511: [Bug] - Fixed Broken Links at Licensing & K8S Cluster Setup on AWS
Posted by GitBox <gi...@apache.org>.
adithyaakrishna commented on a change in pull request #10511:
URL: https://github.com/apache/pulsar/pull/10511#discussion_r628709651
##########
File path: site2/website/coding-guide.md
##########
@@ -20,7 +20,7 @@ Apache Pulsar uses the following libraries a lot:
Use these libraries whenever possible rather than introducing more dependencies.
-Dependencies are bundled with our binary distributions, so we need to attach the relevant licenses. See [Third party dependencies and licensing](/community/licensing) for a guide on how to do it correctly.
+Dependencies are bundled with our binary distributions, so we need to attach the relevant licenses. See [Third party dependencies and licensing](https://pulsar.apache.org/docs/en/client-libraries/) for a guide on how to do it correctly.
Review comment:
Okay Sure, Thanks a lot 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #10511: [Bug] - Fixed Broken Links at Licensing & K8S Cluster Setup on AWS
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #10511:
URL: https://github.com/apache/pulsar/pull/10511#discussion_r628650406
##########
File path: site2/website/coding-guide.md
##########
@@ -20,7 +20,7 @@ Apache Pulsar uses the following libraries a lot:
Use these libraries whenever possible rather than introducing more dependencies.
-Dependencies are bundled with our binary distributions, so we need to attach the relevant licenses. See [Third party dependencies and licensing](/community/licensing) for a guide on how to do it correctly.
+Dependencies are bundled with our binary distributions, so we need to attach the relevant licenses. See [Third party dependencies and licensing](https://pulsar.apache.org/docs/en/client-libraries/) for a guide on how to do it correctly.
Review comment:
I'm not sure whether it's the correct link for the dependencies and licensing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] adithyaakrishna commented on a change in pull request #10511: [Bug] - Fixed Broken Links at Licensing & K8S Cluster Setup on AWS
Posted by GitBox <gi...@apache.org>.
adithyaakrishna commented on a change in pull request #10511:
URL: https://github.com/apache/pulsar/pull/10511#discussion_r628706758
##########
File path: site2/website/coding-guide.md
##########
@@ -20,7 +20,7 @@ Apache Pulsar uses the following libraries a lot:
Use these libraries whenever possible rather than introducing more dependencies.
-Dependencies are bundled with our binary distributions, so we need to attach the relevant licenses. See [Third party dependencies and licensing](/community/licensing) for a guide on how to do it correctly.
+Dependencies are bundled with our binary distributions, so we need to attach the relevant licenses. See [Third party dependencies and licensing](https://pulsar.apache.org/docs/en/client-libraries/) for a guide on how to do it correctly.
Review comment:
@Jennifer88huang I went through Pulsar docs, and thought this could be the one. If there are any changes, please do let me know, I'll be glad to fix it up :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] adithyaakrishna commented on pull request #10511: [Bug] - Fixed Broken Links at Licensing & K8S Cluster Setup on AWS
Posted by GitBox <gi...@apache.org>.
adithyaakrishna commented on pull request #10511:
URL: https://github.com/apache/pulsar/pull/10511#issuecomment-846422280
Yay! 🎉
Thanks @codelipenghui & @Jennifer88huang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org