You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/22 11:35:33 UTC

[GitHub] [doris] dataroaring commented on a diff in pull request #15209: [test]add alert func when running regression-test

dataroaring commented on code in PR #15209:
URL: https://github.com/apache/doris/pull/15209#discussion_r1055369911


##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/Config.groovy:
##########
@@ -79,6 +79,13 @@ class Config {
     public InetSocketAddress metaServiceHttpInetSocketAddress
     public Integer parallel
     public Integer suiteParallel
+
+    public String repo
+    public String testBranch
+    public String serverUrl
+    public String pipelineId
+    public String buildId
+

Review Comment:
   Can we put item here in others like webhook?  repo, serverUrl is to general, maybe repoName, xxServerUrl?



##########
regression-test/conf/regression-conf.groovy:
##########
@@ -88,6 +88,9 @@ es_6_port=19200
 es_7_port=29200
 es_8_port=39200
 
+alertOn="CLOSE"
+webhook=""

Review Comment:
   Please add comment for alterOn and webhook.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org