You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/13 06:50:33 UTC
[GitHub] [cloudstack-primate] borisstoyanov opened a new issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
borisstoyanov opened a new issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803
**Describe the bug**
When deploying a VM with data disks, the UI will show you just the default offerings instead all.
All offerings:
When deploying template with data disksk
Comment from Hari:
For fixed disk offerings we need to have data disk offerings which are either 5GB and above or custom disk offerings, since the data disk is of 5GB it is looking for suitable disk offerings. The one in the screenshots are less than 5GB
Even then I see a bug where the listDiskOfferingCmd is properly listing all disk offerings but primate is not showing any custom disk offerings in case of multi disk templates.
**Additional context**
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-708194558
@utchoang It already filters offerings >= 5GB. Need to confirm whehter custom disk offerings are supported for datadisk templates or not @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-708194558
@utchoang listDiskOfferings returns all the disk offerings, but Primate filters offerings >= 5GB. Need to confirm whether custom disk offerings are supported for data disk templates or not @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-708200313
@andrijapanicsb I think supporting custom disk sizes will require several backend chagnes since right now it isn't supported
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] borisstoyanov commented on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-708925393
I think it'll be good if customer is able to select bigger or smaller offering for the data disks, and it's not just the size but every other option that a custom predefined offering allows you to do (like for example tags to deploy the disk to a specific pool). Should we do it now or now is a separate question, but definitely worths having it.
--jsut my 2 cents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] borisstoyanov commented on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-711917373
ok, lets close and reopen when backend support is available
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-708203074
I didn't ask for it - we are now in GA - and ues, backend changes, below is my take on it:
it's not only the UI - it's also the backend - and IF we should support it or not - probably NOT - as we don't have (atm) a way for ACS to validate if the customer wanted to cheat by choosing a smaller custom disk size, than the real volume size (from the template, 5GB in this example, but couild be anything...) - thus tricking the billing (we don't resize or anything - we just assign an offering in the DB, for billing purposes - AFAIK)
Also, starting from 4.15 and onwards, any newly registered template (for VMware, as this bug is related to VMware only) - we are using templates as they are - i.e. NO choosing of offering for each disk, or anything (in background we assign each disk/volume to a custom offering with the same size as the size of the volume) - so absolutely no need to invest any effor here - IMO at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb edited a comment on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
andrijapanicsb edited a comment on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-709471375
As long as the user doesn't shoot himself in the foot - I agree - let's leave this for 1.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] borisstoyanov commented on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-708191701
I think so @utchoang, @andrijapanicsb @nvazquez can you confirm
cc: @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-707585091
@borisstoyanov @rhtyd cc @svenvogel So does that mean the list disk offering will include data disk offering with value `>= 5 GB` and the custom disk offering?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-709471375
As long as the customer doesn't shoot himself in the foot - I agree - let's leave this for 1.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-708198401
It's always easy to see how the old UI works - what offerings are listed there.
Afaik, this is multidisk template - where you match offering to a data disk from the template - and only the ones with size >= "volume size from template" are shown.
Not sure abou the custom offerings though - I just checked on old UI - both the stock and the new one (custom offering) are NOT showing.
I think this is OK - since the custom disk offering can be smaller than 5GB (volume size from the template) - and we don't want to allow that (we also hide fixed disk offerings smaller than 5GB, just checked on the old UI) -
In theory, this could be done better, as there is a "custom.diskoffering.size.min" global setting - even when setting this one to 6 (6GB) atm we doesnt't show it in that offering list in deployment wizard (theoretically, it should, as we Set the min custom disk size to be BIGGER than the volume-from-template size)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] borisstoyanov closed issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
borisstoyanov closed issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #803: [BUG] When deploying VM, disk offering for data disks are not all listed
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #803:
URL: https://github.com/apache/cloudstack-primate/issues/803#issuecomment-709881605
Since custom disk offerings aren't supported yet in the backend, can close this and reopen once support has been added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org