[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8881: KIP-557: Add emit on change support to Kafka Streams

[GitBox <gi...@apache.org>]

ConcurrencyPractitioner commented on pull request #8881:
URL: https://github.com/apache/kafka/pull/8881#issuecomment-644904629


   @vvcephei Just wanted to get your opinion on this. When adding emit-on-change support to ```KTableFilter```, I found that the old value was already available for us in certain situations.
   I thought that in this case, it would be wasteful if we just queried the store only to retrieve the timestamp. To that end, I decided that the value for ```serializedOldValue``` will simply just be ```ValueAndTimestamp(oldValue, 0)```. My reasoning is that the old value is guaranteed to have a smaller timestamp than the new value. So any value less than the current timestamp would suffice. I chose 0 just to be safe. Do you think this is safe?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org