You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "changliiu (via GitHub)" <gi...@apache.org> on 2025/07/08 20:53:20 UTC
[PR] fix endtimestamp issue [beam]
changliiu opened a new pull request, #35544:
URL: https://github.com/apache/beam/pull/35544
fix endtimestamp issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix endtimestamp issue [beam]
Posted by "dedocibula (via GitHub)" <gi...@apache.org>.
dedocibula commented on code in PR #35544:
URL: https://github.com/apache/beam/pull/35544#discussion_r2193617190
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java:
##########
@@ -178,6 +178,7 @@ public ProcessContinuation run(
BundleFinalizer bundleFinalizer) {
final String token = partition.getPartitionToken();
final Timestamp startTimestamp = tracker.currentRestriction().getFrom();
+ final Timestamp endTimestamp = partition.getEndTimestamp();
final Timestamp changeStreamQueryEndTimestamp =
partition.getEndTimestamp().equals(MAX_INCLUSIVE_END_AT)
Review Comment:
swap partition.getEndTimestamp() for endTimestamp here and in the else case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix endtimestamp issue [beam]
Posted by "changliiu (via GitHub)" <gi...@apache.org>.
changliiu commented on code in PR #35544:
URL: https://github.com/apache/beam/pull/35544#discussion_r2193641930
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java:
##########
@@ -178,6 +178,7 @@ public ProcessContinuation run(
BundleFinalizer bundleFinalizer) {
final String token = partition.getPartitionToken();
final Timestamp startTimestamp = tracker.currentRestriction().getFrom();
+ final Timestamp endTimestamp = partition.getEndTimestamp();
final Timestamp changeStreamQueryEndTimestamp =
partition.getEndTimestamp().equals(MAX_INCLUSIVE_END_AT)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix endtimestamp issue [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad merged PR #35544:
URL: https://github.com/apache/beam/pull/35544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix endtimestamp issue [beam]
Posted by "dedocibula (via GitHub)" <gi...@apache.org>.
dedocibula commented on code in PR #35544:
URL: https://github.com/apache/beam/pull/35544#discussion_r2193615902
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java:
##########
@@ -178,6 +178,7 @@ public ProcessContinuation run(
BundleFinalizer bundleFinalizer) {
final String token = partition.getPartitionToken();
final Timestamp startTimestamp = tracker.currentRestriction().getFrom();
+ final Timestamp endTimestamp = partition.getEndTimestamp();
Review Comment:
tracker.currentRestriction().getTo()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix endtimestamp issue [beam]
Posted by "changliiu (via GitHub)" <gi...@apache.org>.
changliiu commented on code in PR #35544:
URL: https://github.com/apache/beam/pull/35544#discussion_r2193636695
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java:
##########
@@ -178,6 +178,7 @@ public ProcessContinuation run(
BundleFinalizer bundleFinalizer) {
final String token = partition.getPartitionToken();
final Timestamp startTimestamp = tracker.currentRestriction().getFrom();
+ final Timestamp endTimestamp = partition.getEndTimestamp();
Review Comment:
Discussed offline. We tend to keep it as what it was before https://github.com/apache/beam/pull/34967/files#diff-27377e3a89fd3c10f49fa607cdaa825aed58daaa14c54b9a0ddc5030fe165e36.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org