You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/27 08:43:44 UTC

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2106: Run, debug JVM JavaScript with Graal.js as well as Nashorn

JaroslavTulach commented on a change in pull request #2106:
URL: https://github.com/apache/netbeans/pull/2106#discussion_r415625171



##########
File path: java/java.source.ant/src/org/netbeans/modules/java/source/ant/ProjectRunnerImpl.java
##########
@@ -122,8 +122,7 @@
     private static final RequestProcessor RP = new RequestProcessor(ProjectRunnerImpl.class);
     
     public boolean isSupported(String command, Map<String, ?> properties) {
-        return BuildArtifactMapper.isCompileOnSaveSupported() &&
-               locateScript(command) != null;
+        return locateScript(command) != null;

Review comment:
       Without this change, @jlahoda, the Ant runner refused to perform `run` and `debug` actions. I am sure the check is here for a reason, but it is probably not correct to prevent `run`/`debug` just because we don't have `nbjavac` installed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists