You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/29 10:58:24 UTC

[GitHub] [inlong] woofyzhao commented on a diff in pull request #6046: [INLONG-6044][Manager] Distinguish between group and stream configuration processes

woofyzhao commented on code in PR #6046:
URL: https://github.com/apache/inlong/pull/6046#discussion_r983393423


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/group/InitGroupCompleteListener.java:
##########
@@ -84,12 +87,9 @@ public ListenerResult listen(WorkflowContext context) throws WorkflowListenerExc
         updateGroupRequest.setVersion(existGroup.getVersion());
         groupService.update(updateGroupRequest, operator);
 
-        // update status of other related configs
-        streamService.updateStatus(groupId, null, StreamStatus.CONFIG_SUCCESSFUL.getCode(), operator);
-        if (InlongConstants.LIGHTWEIGHT_MODE.equals(groupInfo.getLightweight())) {

Review Comment:
   this condition branch seems to be missing from the stream side's counterpart



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org