You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/09/07 21:32:16 UTC

[GitHub] [commons-collections] scordio opened a new pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

scordio opened a new pull request #250:
URL: https://github.com/apache/commons-collections/pull/250


   This prevents modifications via [`pollFirst()`](https://docs.oracle.com/javase/7/docs/api/java/util/NavigableSet.html#pollFirst()) and [`pollLast()`](https://docs.oracle.com/javase/7/docs/api/java/util/NavigableSet.html#pollLast()) for `UnmodifiableNavigableSet` instances.
   
   https://issues.apache.org/jira/browse/COLLECTIONS-799
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #250:
URL: https://github.com/apache/commons-collections/pull/250#issuecomment-914645718


   
   [![Coverage Status](https://coveralls.io/builds/42722290/badge)](https://coveralls.io/builds/42722290)
   
   Coverage decreased (-0.03%) to 90.115% when pulling **18bb8734d69b3729402bcae8f0e5a12fdc80774d on scordio:COLLECTIONS-799-UnmodifiableNavigableSet** into **ddb4f78cfffc3392d897f7d59b75db946bf3a055 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] scordio commented on pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

Posted by GitBox <gi...@apache.org>.
scordio commented on pull request #250:
URL: https://github.com/apache/commons-collections/pull/250#issuecomment-970881601


   @kinow do you know when the next version will be released? I'd be happy to have this fix available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] scordio commented on pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

Posted by GitBox <gi...@apache.org>.
scordio commented on pull request #250:
URL: https://github.com/apache/commons-collections/pull/250#issuecomment-915104258


   Should I add an entry to `changes.xml` or is that part of the merge process?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] scordio commented on pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

Posted by GitBox <gi...@apache.org>.
scordio commented on pull request #250:
URL: https://github.com/apache/commons-collections/pull/250#issuecomment-1013968888


   Hi @kinow, I was wondering if a release is in sight. No pressure, just curiosity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow commented on pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #250:
URL: https://github.com/apache/commons-collections/pull/250#issuecomment-970984082


   @scordio it only depends on one of the committers to volunteer for a RM. I might be able to cut a release in December or January if others are too busy (planning to release Text/Imaging/Lang too if possible these next holidays).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] garydgregory commented on a change in pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #250:
URL: https://github.com/apache/commons-collections/pull/250#discussion_r704062226



##########
File path: src/test/java/org/apache/commons/collections4/set/UnmodifiableNavigableSetTest.java
##########
@@ -143,6 +143,23 @@ public void verifyUnmodifiable(final Set<E> set) {
         } catch (final UnsupportedOperationException e) {
             // expected
         }
+
+        if (set instanceof NavigableSet) {
+            final NavigableSet<E> navigableSet = (NavigableSet<E>) set;
+
+            try {

Review comment:
       Too verbose, use assertThrows().




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls commented on pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #250:
URL: https://github.com/apache/commons-collections/pull/250#issuecomment-914645718


   
   [![Coverage Status](https://coveralls.io/builds/42711558/badge)](https://coveralls.io/builds/42711558)
   
   Coverage increased (+0.001%) to 90.145% when pulling **6387e46c996ce335dbaec875a8344c4be3f7f030 on scordio:COLLECTIONS-799-UnmodifiableNavigableSet** into **ddb4f78cfffc3392d897f7d59b75db946bf3a055 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow closed pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

Posted by GitBox <gi...@apache.org>.
kinow closed pull request #250:
URL: https://github.com/apache/commons-collections/pull/250


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow commented on pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #250:
URL: https://github.com/apache/commons-collections/pull/250#issuecomment-939203539


   Merged! Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow commented on pull request #250: COLLECTIONS-799 - Prevent modifications of `UnmodifiableNavigableSet`

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #250:
URL: https://github.com/apache/commons-collections/pull/250#issuecomment-939203164


   > Should I add an entry to `changes.xml` or is that part of the merge process?
   
   That's part of the merge process, since a committer normally goes in the `dev` field, and the contributor name/id goes in the `due-to` field, so we need to wait to see which committer will be merging it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org