You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/17 23:19:26 UTC

[GitHub] [beam] chamikaramj commented on a change in pull request #13957: [BEAM-11787] Removes new VR test that fails for Dataflow

chamikaramj commented on a change in pull request #13957:
URL: https://github.com/apache/beam/pull/13957#discussion_r578013200



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations_test.py
##########
@@ -254,7 +254,6 @@ def expand(self, pcoll):
           | Create([('a', x) for x in vals])
           | 'multiple-combines' >> MultipleCombines())
 
-  @attr('ValidatesRunner')

Review comment:
       I think Combiner packing was disabled for both DataflowRunner and PortableRunner so don't think this test is useful currently. We should add this back when CombinerPacking is enabled for various runners.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org