[GitHub] [geode] BenjaminPerryRoss opened pull request #2913: Added error for no members found in CreateDataSourceCommand

["BenjaminPerryRoss (GitHub)" <gi...@apache.org>]

- Added an error case for when no servers are available when
CreateDataSourceCommand is run and Cluster Config is not enabled

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2913 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jchen21 commented on pull request #2913: GEODE-6066: Added error for no members found in CreateDataSourceCommand

["jchen21 (GitHub)" <gi...@apache.org>]

What's the difference between the two cases when service is not null and service is null? The error messages are the same. However one is a info, and the other is an error. I assume the messages would be different. Would you please explain a bit more?

[ Full content available at: https://github.com/apache/geode/pull/2913 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jchen21 commented on pull request #2913: GEODE-6066: Added error for no members found in CreateDataSourceCommand

["jchen21 (GitHub)" <gi...@apache.org>]

The error message should be: No members found and cluster configuration disabled.
The info message is just telling you that no members were found but it was still created in cluster config.

[ Full content available at: https://github.com/apache/geode/pull/2913 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jchen21 closed pull request #2913: GEODE-6066: Added error for no members found in CreateDataSourceCommand

["jchen21 (GitHub)" <gi...@apache.org>]

[ pull request closed by jchen21 ]

[ Full content available at: https://github.com/apache/geode/pull/2913 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org