[GitHub] felixcheung commented on a change in pull request #23337: [SPARK-26019][PYSPARK] Allow insecure py4j gateways

[GitBox <gi...@apache.org>]

felixcheung commented on a change in pull request #23337: [SPARK-26019][PYSPARK] Allow insecure py4j gateways
URL: https://github.com/apache/spark/pull/23337#discussion_r242820273
 
 

 ##########
 File path: python/pyspark/context.py
 ##########
 @@ -112,6 +112,18 @@ def __init__(self, master=None, appName=None, sparkHome=None, pyFiles=None,
         ValueError:...
         """
         self._callsite = first_spark_call() or CallSite(None, None, None)
+        if gateway is not None and gateway.gateway_parameters.auth_token is None:
+            if conf and conf.get("spark.python.allowInsecurePy4j", "false") == "true":
 
 Review comment:
   If I recall, I don't think we can set SparkConf, so to me env var is better.
   of course @zjffdu should know best at this point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org