You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Revolyssup (via GitHub)" <gi...@apache.org> on 2023/05/18 14:44:45 UTC
[GitHub] [apisix] Revolyssup commented on a diff in pull request #9506: fix: replace mock tests with real tests in udp-logger
Revolyssup commented on code in PR #9506:
URL: https://github.com/apache/apisix/pull/9506#discussion_r1197917079
##########
t/plugin/udp-logger.t:
##########
@@ -410,10 +383,9 @@ the mock backend is hit
"port": 8125,
"tls": false,
"log_format": {
+ "case name": "logger format in plugin",
"vip": "$remote_addr"
- },
- "batch_max_size": 1,
Review Comment:
that must have been by mistake. I was testing few things out. I'll remove it.
##########
t/plugin/udp-logger.t:
##########
@@ -410,10 +383,9 @@ the mock backend is hit
"port": 8125,
"tls": false,
"log_format": {
+ "case name": "logger format in plugin",
"vip": "$remote_addr"
- },
- "batch_max_size": 1,
Review Comment:
that must have been by mistake. I was testing few things out. I'll readd it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org