You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/01 07:29:50 UTC
[GitHub] [spark] viirya commented on a change in pull request #31656: [SPARK-34548][SQL] Remove unnecessary children from Union under Distince and Deduplicate
viirya commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r584493655
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala
##########
@@ -860,6 +860,22 @@ class DataFrameSetOperationsSuite extends QueryTest with SharedSparkSession {
}
}
}
+
+ test("SPARK-34548: Remove unnecessary children from Union") {
+ Seq(RemoveNoopUnion.ruleName, "").map { ruleName =>
+ withSQLConf(SQLConf.OPTIMIZER_EXCLUDED_RULES.key -> ruleName) {
+ val testData_2 = spark.sparkContext.parallelize(
Review comment:
Renamed to `testDataCopy`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org