You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/12 16:55:30 UTC

[GitHub] [hudi] n3nash commented on pull request #1242: [HUDI-544] Archived commits command code cleanup

n3nash commented on pull request #1242:
URL: https://github.com/apache/hudi/pull/1242#issuecomment-643382309


   @hddong 
   > @hddong I'm accepting and will merge after you create another ticket for us to add to the release notes that if someone was actually overriding HOODIE_ARCHIVELOG_FOLDER_PROP_NAME that was not being honored before and now will be honored for those cases it can break (since this is the right thing to do)
   
   This is what I had commented. So this change will break if someone was overriding this prop name  and expecting that path to be used (but it was actually not since it was never used). can you open a ticket for us to add this to the release notes and we can merge then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org